[ http://issues.apache.org/jira/browse/AXIS2C-397?page=all ]
Samisa Abeysinghe updated AXIS2C-397:
-------------------------------------
Fix Version/s: 0.96
> Rampart Utils - Some Code Improvements
> --------------------------------------
>
> Key: AXIS2C-397
> URL: http://issues.apache.org/jira/browse/AXIS2C-397
> Project: Axis2-C
> Issue Type: Improvement
> Components: rampart
> Affects Versions: Current (Nightly)
> Environment: All
> Reporter: Nabeel Yoosuf
> Assigned To: Malinda Kaushalye Kapuruge
> Priority: Minor
> Fix For: 0.96
>
>
> I had a quick glance at some of the files in rampart utils..Some suggestions
> 1. In some functions the same value is recalculated several times which is
> not efficient.
> E.g.
> rampart_utils.c:rampart_generate_nonce(..)
> OXS_BUFFER_GET_SIZE(buffer, env)
> rampart_cryto_utils.c:rampart_crypto_sha1(..)
> axis2_base64_decode_len(nonce)
> 2. Memory leaks
> E.g.
> rampart_crypt_utils.c:45 - what is allocated is not freed
> 3. I find many printf's - are these for debugging? the better way is to
> perform a runtime debugging.
> Thanks
> -Nabeel
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
