I am +1 for using #ifdef s in the module directly. - Nandika
On 2/19/07, Jared Hanson <[EMAIL PROTECTED]> wrote:
Glad to hear you're interested in the code. It's one of my top priorities to get this building against svn head this week. I'll be submitting patches as I complete tasks. One question I did have: Right now I split out the static deployment engine code, so it is completely outside of the axis2c code base. However, it turns out that about 95% of the code is a copy of what is in axis2c (configuration parsing, etc). As I work off head, I'd like to avoid this duplication. One option that is available is just using a #ifdef directly in the code, usually in the deployment module. For example: #ifdef AXIS2_STATIC_DEPLOY /* Do static deployment step */ #else /* Do normal dynamic deployment step */ #endif Another option is to make a separate static deployment module. This option avoids the #ifdef pragmas, but would require more refactoring in order to move the common code to a place that can be shared by both the static and dynamic deployment modules. If anyone has any opinions on this, please make them known. Also, as you get a chance to review the code I uploaded, let me know any changes you would like made. - Jared On 2/17/07, Dinesh Premalal <[EMAIL PROTECTED]> wrote: > > Hi Jared, > > "Jared Hanson" <[EMAIL PROTECTED]> writes: > > I've uploaded the code for the Axis2/C static deployment engine that > > I've been referring to. It can be downloaded from: > > http://www.asperasoft.com/developer/axis2c/axis2-static-deploy.tar.gz > Downloaded sources, Give us some time look through it. > > What is in the package was built against 0.95. As mentioned, there > are some > > issues when building against the trunk. I intend to fix those. > As your previous mail mentioned, there is some refactoring going on the > code base. We removed some of the ops because there was some > performance hiccups. > > Lets try to get it build against the trunk, and put it in the code > base. After that you will be able to do your further development > easily. If we could include, static deployment engine for Axis2/C 1.0 > release that would be great. > > If there is any interest in incorporating this into the project, > > that would be welcome. > Definitely !, we are open to embrace any constructive ideas or > contributions. > >Please ask if you have any questions. Any suggestions are > > appreciated. > Appreciate your effort on Static Deployment Engine. Lets try to get it > on svn head soon. > > thanks, > Dinesh > -- > Dinesh Premalal > [EMAIL PROTECTED] > WSO2, Inc.; http://www.wso2.com/ > GPG Key ID : A255955C > GPG Key Finger Print : C481 E5D4 C27E DC34 9257 0229 4F44 266E A255 > 955C > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > >
-- [EMAIL PROTECTED]
