[ 
https://issues.apache.org/jira/browse/AXIS2C-645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569636#action_12569636
 ] 

Sahan Gamage commented on AXIS2C-645:
-------------------------------------

Hi Senaka,

It has been a while since I created this issue and the requirement came from 
Sandesha side. I am not quite sure if they have found a way around this 
particular issue and hence still exists. But here's my explanation :
Passing configuration context to module_shutdown() will not create an extra 
dependency on core at least on library/code wise because we're already passing 
conf_ctx to the module_init() function. Are you talking about any other 
dependancy ?
Also, the functions defined in the axis2_module.h are indeed the interface 
points between core and the particular module. I don't see a violation of 
abstraction when we add conf_ctx to the module_shutdown() function defined in 
this interface.
As you said, cleaning up module specific data is indeed module's task and 
that's why the shutdown function exists; axis2 core gives the module a chance 
to clean up the things it has created before going away and these things may 
not be simple objects, they can be as complicated as db connections. The 
modules add/change some properties to the configuration context in order to 
maintain it's life-cycle in the message processing pipe. If the module gets 
shutdown it needs to clean up this data inside the shutdown function and hence 
need access to the conf_ctx inside the shutdown() function. Is there any other 
way to get around this thing ?



> Need to pass configuration context to axis2_module_shutdown()
> -------------------------------------------------------------
>
>                 Key: AXIS2C-645
>                 URL: https://issues.apache.org/jira/browse/AXIS2C-645
>             Project: Axis2-C
>          Issue Type: Improvement
>          Components: core/description
>    Affects Versions: Current (Nightly)
>            Reporter: Sahan Gamage
>            Priority: Minor
>
> We need to pass configuration context to module shutdown function since 
> modules might have pushed module specific data as parameters to configuration 
> context. Cleaning module specific data by the module itself and not by the 
> axis2 core is the most suitable way I believe.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to