Senaka, after this change I'm seeing a Windows warning on http_transport_utils.c that, with /WX, causes the build to fail. Using VS 2005, it says that line 345 refers to atoi, and atoi will be assumed to be an external returning int. Maybe this is a Windows warning you did not see on a different version of Visual Studio.
Obviously, the quick fix for me is to remove the /WX locally. Bill -----Original Message----- From: Senaka Fernando [mailto:[EMAIL PROTECTED] Sent: Tuesday, February 19, 2008 11:56 AM To: Apache AXIS C Developers List Subject: Re: Windows build break Hi Samisa, After I removed the warnings on Windows, to make sure we don't repeat the same mistakes over and over, and to ensure that we make it a point to check for warnings on windows, I have set the warn to error flag on Windows, as well as setting the warning level to 3. Therefore, making sure that a file builds with gcc on Unix does not guarantee that you wont see build breaks on Windows. We rather not remove this warn to error flag, and must only remove it when we pack. Therefore it might be a common scenario for windows developers to see build breaks. However, it would be a different scenario for users, who would rather not see at least a warning. And, Dinesh please make it a point to remove the /WX flags when you pack, at least until we figure out how to remove it using our dist scripts. Regards, Senaka > Samisa Abeysinghe wrote: >> mime_parser.c >> ..\..\axiom\src\attachments\mime_parser.c(118) : error C2057: >> expected constant expression >> ..\..\axiom\src\attachments\mime_parser.c(118) : error C2466: cannot >> allocate an array of constant size 0 >> ..\..\axiom\src\attachments\mime_parser.c(118) : error C2133: >> 'buf_array' : unknown size >> ..\..\axiom\src\attachments\mime_parser.c(119) : error C2057: >> expected constant expression >> ..\..\axiom\src\attachments\mime_parser.c(119) : error C2466: cannot >> allocate an array of constant size 0 >> ..\..\axiom\src\attachments\mime_parser.c(119) : error C2133: >> 'len_array' : unknown size > > I also think that there is a logical error in this code: > > axis2_char_t *buf_array[mime_parser->max_chunk_buffers]; > int len_array[mime_parser->max_chunk_buffers]; > > Should the two arrays be of the size max_chunk_buffers? > > And the syntax error is because the static variable is declared with > variable size. Should use a dynamic allocation. > > Samisa... --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
