[
https://issues.apache.org/jira/browse/AXIS2C-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12791165#action_12791165
]
S.Uthaiyashankar commented on AXIS2C-1325:
------------------------------------------
Changing WIN32 to _WIN32 in the public includes is enough. We don't need to
change in .C files because WIN32 is defined in the make files.
> _WIN32 should be used instead of WIN32
> --------------------------------------
>
> Key: AXIS2C-1325
> URL: https://issues.apache.org/jira/browse/AXIS2C-1325
> Project: Axis2-C
> Issue Type: Bug
> Components: build system (Windows)
> Affects Versions: 1.5.0
> Environment: WIN64
> Reporter: Patrick van Beem
> Assignee: S.Uthaiyashankar
> Priority: Minor
> Fix For: 1.7.0
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> In several places, the WIN32 macro is used to check if we're running on
> Windows or not. This macro is defined in the make file (and usually by VS in
> the any WIN32 project too).
> However, when users are using the library in a 64-bit windows environment,
> WIN32 is not defined, so the tests for the WIN32 macro in the axis include
> files in the distribution, fail (when they should not, because we are in a
> windows environment).
> We should either use _WIN32 instead (which is always defined by the MS
> compiler in both 32-bit and 64-bit) or use something like:
> #if defined(WIN32) || defined(WIN64)
> to check for windows. I prefer _WIN32, because that's implicit defined while
> WIN32 and WIN64 must be defined explicit.
> This change should be made at least in the public includes (since WIN32 is
> defined in the makefile, the change would have no effect internally).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
