Subra A Narayanan wrote:
Just some additional comments:
I think we definitely need the length function because there is no
other way of retrieving the length of the input stream as the
definition of the axiom_data_handler struct is in data_handler.c file
and not in axiom_data_handler.h file. So my question is, should the
declaration of the axiom_data_handler struct be moved to
axiom_data_handler.h file?
I have made these simple changes to my local copy of the files. If you
want I can send it over to you guys and you can check it in after
reviewing the changes.
Please do 'svn diff' and send the diff. I will have a look and committ in.
BTW, the reason to have the struct in the C file was for data hiding
purposes. We can add an accessor method, so that it would be in sync
with the rest of the code.
Thanks,
Samisa...
Thanks!!
Subra
On 8/16/07, *Subra A Narayanan* <[EMAIL PROTECTED]
<mailto:[EMAIL PROTECTED]>> wrote:
Hello folks,
I was looking at data_handler.c file and came across this function
AXIS2_EXTERN axis2_byte_t * AXIS2_CALL
axiom_data_handler_get_input_stream(axiom_data_handler_t
*data_handler,
const axutil_env_t *env)
{
return (axis2_byte_t *)"";
}
The above function always returns null. Should the above line be:
return (axis2_byte_t *)data_handler->buffer;
Also, would it be useful to have a function called
axiom_data_handler_get_input_stream_len?
Subra
--
Samisa Abeysinghe : WSO2 WSF/C
"http://wso2.org/projects/wsf/c?WSO2 Web Services Framework/C - Open source C library for providing and consuming Web services";
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
