I don't personally like this change. I would much rather take a "mangle if we have to" approach, where we compare symbols to a list of reserved words (I thought we were already doing this somewhere?) and only mangle them if necessary.
Plus it seems to break the tests (?). -1 for now. --Glen ----- Original Message ----- From: <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Thursday, February 27, 2003 7:36 PM Subject: cvs commit: xml-axis/java/src/org/apache/axis/wsdl/toJava JavaBeanWriter.java > jmsnell 2003/02/27 16:36:10 > > Modified: java/src/org/apache/axis/wsdl/toJava JavaBeanWriter.java > Log: > Partial Fix http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14137 > > Changed JavaBeanWriter so that all local variables are prefixed with > an underscore. This is required to avoid name collisions that occur > when schema elements use java keywords for their names. > > Revision Changes Path > 1.35 +1 -1 xml-axis/java/src/org/apache/axis/wsdl/toJava/JavaBeanWriter.java > > Index: JavaBeanWriter.java > =================================================================== > RCS file: /home/cvs/xml-axis/java/src/org/apache/axis/wsdl/toJava/JavaBeanWriter.java,v > retrieving revision 1.34 > retrieving revision 1.35 > diff -u -r1.34 -r1.35 > --- JavaBeanWriter.java 28 Feb 2003 00:32:22 -0000 1.34 > +++ JavaBeanWriter.java 28 Feb 2003 00:36:09 -0000 1.35 > @@ -505,7 +505,7 @@ > if (enableSetters) { > pw.println(" public void set" + capName + "(" + > typeName + " " + Utils.addUnderscore(name) + ") {"); > - pw.println(" this." + Utils.addUnderscore(name) + " = " + name + ";"); > + pw.println(" this." + Utils.addUnderscore(name) + " = " + Utils.addUnderscore(name) + ";"); > pw.println(" }"); > pw.println(); > } > > > >
