On Apr 12, 2005 12:58 PM, jayachandra <[EMAIL PROTECTED]> wrote: > Hi devs! > > Currently OMNodeImpl has the data memeber 'parent' of type OMElement. > This appears problematic. Because for document level comments (i mean, > comments that are present outside the root element in the XML > document) parent becomes OMDocument rather than OMElement. So better > have the 'parent' data member as Object. And accordingly the return > type of getParent will be Object. I hope this change will not break > any existing code, will it???
This will not break any of the code. But this will add some bad things, IMHO, to code. For example, anything can be a parent of any node, even a Text node. That was the main reason why, we purposely made parent to an OMElement. I understand your concern, but ............ And there is another question coming from me, is it necessary to provice the ability to add comments to the Document which is even out of the document element ?? Making this available is of not that useful, but will add some weird look to the code. We earlier had the concept of OMDocument, but later removed it. For your all information : These days all the Sri Lankan people have gone home to celebrate our Sinhalese new year festival. So, there may be (including me), a deley in replying to the mails. :( Regards, Chinthaka > > Jaya > -- > -- Jaya > -- -------------------------------------------------------- Eran Chinthaka
