Hi Glen and all,

> 
> Hi folks!
> 
> I'm re-ramping up on the current state of Axis2, and hoping to dive in
> for some substantive coding work in the next few days (some work on
> modules and looking into RPC/enc).  As I'm going through the code, I
> notice a few things:
> 
> * Formatting inconsistencies all over the place... can we run the whole
> codebase through IDEA's "reformat code" tool?  (+1 from me!)

+1 from me too. If some one can setup his IDE and save the code template and
send to us, that will be easy to share the same code style. So for others we
can enforce that by asking to put that template in the {IDEA_HOME}
\config\codestyles folder.

Sorry I can not volunteer to this as I'm bit uncertain about some coding
styles. But if some one lays down them here, I can help :).

> 
> * We decided on either 80 or 100 char lines back in December (seach the
> archives for "80 columns"), and yet there are a lot of lines > 120 chars.
> 
> * Lack of comments.  It is really important to have at least some notion
> of what each class is for, and ideally a good explanation, in the
> JavaDoc header for that class (ditto for methods).  Lots of our current
> classes/methods are missing any comments.

Will do this. I also need some time to do it.

Regards,
Chinthaka

> 
> Can folks try to rectify these things as we continue to work in various
> places?
> 
> Thanks,
> --Glen
> 
> P.S.  I'm super-pleased at the speed and size so far!!  Nice job!
> 



Reply via email to