[ http://issues.apache.org/jira/browse/AXIS2-253?page=comments#action_12331021 ]
Thilina Gunarathne commented on AXIS2-253: ------------------------------------------ Nope.... IMHO HTTPTransportUtils is the correct place for that piece of code(doWriteMTOM()). AbstractTransportSender is not the correct place to check for MTOM optimising of a message. Also to have the MTOM deals only with HTTP transport. There's no point in putting MTOM for SMTP, simply because SMTP is a text protocol. IIRC there aren't any MIME like packging defined for TCP too. IMO MTOM comes in to play only in HTTP case... So this should go to CommonsHttpSender For an example If we are using tcp based transport and have a mtom-enabled message with optimised content , then the current Axis2 will try to send a MTOMized message....IMO this is not acceptable at all. IIRC this MTOM checking code was originally in the HttpTransportSender (which is now deprecated due to the use of CommonsHTTPSender) which was the right place for it. No idea how it became a part of AbstractSender. > AbstractTransportSender uses the HTTPTransportUtils to check for MTOM > optimizing of a message > --------------------------------------------------------------------------------------------- > > Key: AXIS2-253 > URL: http://issues.apache.org/jira/browse/AXIS2-253 > Project: Apache Axis 2.0 (Axis2) > Type: Improvement > Components: transports > Reporter: Ruchith Udayanga Fernando > > This is just for clarity. > Can we move the necessary methods to a more generic Util > (org.apache.axis2.transport.TransportUtils ???) class than the > HTTPTransportUtils. IMHO this check is common to all transports. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
