DescriptionBuilder subclasses override AxisConfiguration axisConfig 
inconsistently
----------------------------------------------------------------------------------

         Key: AXIS2-652
         URL: http://issues.apache.org/jira/browse/AXIS2-652
     Project: Apache Axis 2.0 (Axis2)
        Type: Bug

  Components: core  
 Environment: SVN Revision 398594
    Reporter: Jeff Barrett
    Priority: Minor


Three of the four subclasses of DescriptionBuilder (ModuleBuilder, 
ServiceBuilder, ServiceGroupBuilder) override the superclasses's protected 
AxisConfiguration axisConfig variable with their own private version.  When 
both are set (which is in most cases) they are set to the same value.  However, 
in ServiceDescriptionBuilder(InputStrream, AxisConfiguration, AxisService) the 
super.axisConfig is set via a call to super(InputStream, AxisConfiguration); 
however the overridden ServiceDescriptionBuilder.axisConfiguration is not set 
which causes an NPE when axisConfig is used elsewhere in the class without the 
super qualification.

>From looking at the code, I don't think the subclasses need to (or should) 
>override AxisConfiguration.  I will submit a patch shortly with that as the 
>fix.  If I'm wrong and the subclasses do need to override AxisConfiguration, 
>then the fix is to simply set this.axisConfiguration in 
>ServiceDescriptionBuilder(InputStrream, AxisConfiguration, AxisService)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to