[ http://issues.apache.org/jira/browse/AXIS2-761?page=comments#action_12413595 ]
Chuck Williams commented on AXIS2-761: -------------------------------------- Hi Oleg, Thanks for reviewing the patch and sharing your thoughts. Re. (1) I'm not a great fan of complex factory objects either, but it seems the best approach in this case. I thought about class-valued parameters, but a) wanted an enforced construction protocol to simplify writing specialized classes, and b) did not want to introduce reflection into the core http dispatch (currently reflection is only used at configuration time). I'd like to leave this as is unless others object. Re. (2) this was a silly typo -- one of the dangers of naming setter and constructor parameters after the member variables they refer to. I had found it also and a couple others, all fixed in the consolidated patch. Re. (3) I understand the limitation. Perhaps it should be clarified in the comments, but other than this, do you see a need to change HttpFactory? Does the single-threaded constraint on HttpService also imply that one could not have two different SimpleHTTPServers listening on different ports in the same jvm / class loader? Re. my needs for multiple thread pools for different collections of operations, I think this is best done at the message receiver / operation level as it needs to be post-soap-dispatch. I expect this is generally true of all applications with similar needs, so the HttpService limitation is not a problem for this use case. However, I'm using a bounded request queue to protect against the server getting overwhelmed, but would still want administrative requests to get through, whence the idea for a second SimpleHTTPServer listening on an administrative port. Does that sound reasonable to you? FYI to all, my create-lib for the latest svn finally finished (took about 5 hours). The consolidated patch builds and passes all tests in the latest svn head. How do people feel about the new SimpleHTTPServer being committed? > SimpleHttpServer based on Jakarta HttpComponents HttpCore > --------------------------------------------------------- > > Key: AXIS2-761 > URL: http://issues.apache.org/jira/browse/AXIS2-761 > Project: Apache Axis 2.0 (Axis2) > Type: Improvement > Components: transports > Versions: 1.0 > Reporter: Oleg Kalnichevski > Attachments: ConfigurableSimpleHTTPServer.consolidated.patch, > ConfigurableSimpleHTTPServer.patch, jakarta-httpcore-4.0-20060521.jar, > simplehttpserver.patch > > The following patch replaces the SimpleHttpServer implementation based on the > testing framework of Commons HttpClient 3.x with a one based on Jakarta > HttpComponents HttpCore. Compiled against Axis2 trunk and HttpCore trunk > * Removes all references to Commons HttpClient classes > * Enables streaming of schema definitions and similar content > * Improves content buffering of SOAP response > * Improves handling of fault conditions and exception handling > * Fixes a number of NPEs in AxisEngine > * Improves performance and reliability of the HTTP transport -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
