[ 
http://issues.apache.org/jira/browse/AXIS2-803?page=comments#action_12414930 ] 

Eran Chinthaka commented on AXIS2-803:
--------------------------------------

Travis,

Please provide us with a patch (a diff), rather than a complete new file. In 
that way, its easier for us to review the patch, rather than replacing the 
whole thing.

> fix small issue causing null pointer exception, fix typos, add javadoc 
> comments.
> --------------------------------------------------------------------------------
>
>          Key: AXIS2-803
>          URL: http://issues.apache.org/jira/browse/AXIS2-803
>      Project: Apache Axis 2.0 (Axis2)
>         Type: Improvement

>   Components: core
>     Versions: 1.0
>  Environment: any
>     Reporter: Travis Hein
>     Priority: Trivial
>  Attachments: WarBasedAxisConfigurator.java, WarBasedAxisConfigurator_diff.txt
>
> - fix spelling (axis2Steram -> axis2Stream)
> - if axisurl != null case would not set the axisConfig, gave null pointer 
> error on old line #81
> - fix spelling (unableHttp -> enableHttp)
> - add warning message when could not find the axis2.xml anywhere and using 
> default one in classpath resource.
> - externalize init parameter strings as constants and provide documentation.
> - add javadoc comments to class and other methods.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to