[ http://issues.apache.org/jira/browse/AXIS2-961?page=all ]
Davanum Srinivas updated AXIS2-961:
-----------------------------------
Description:
The current state of the phase configuration in axis2.xml is confusing,
especially for beginners.
1) In In-Flow the handler InstanceDispatch is configured to belong to phase
PostDispatch. This phase does not exist in the current configuration.
<handler name="InstanceDispatcher"
class="org.apache.axis2.engine.InstanceDispatcher">
<order phase="PostDispatch"/>
</handler>
2) In In-Flow the handlers RequestURIBasedDispatcher and
SOAPActionBasedDispatcher belong to Transport phase, while in In-Fault-Flow
they belong to phase Dispatch. This should be consistent.
3) The usage of capital letters in phase names should be consistent. Currently
it's inflow, outflow, INfaultflow and Outfaultflow.
4) The comments that are supposed to mark which phases are pre-defined and
where developers can insert custom phases are confusing and misleading. They
also refer to phases that don't exist.
I suggest inserting comments like this:
<!-- Start system pre-defined phases -->
<phase name="X"/>
<phase name="Y"/>
<!-- End system pre-defined phases -->
<!-- Start custom phases -->
<phase name="Z"/>
<!-- End custom phases -->
or like this., respectively:
<!-- Start custom phases -->
<phase name="A"/>
<!-- End custom phases -->
<!-- Start system pre-defined phases -->
<phase name="B"/>
<phase name="C"/>
<!-- End system pre-defined phases -->
Thank you very much,
Thilo
was:
The current state of the phase configuration in axis2.xml is confusing,
especially for beginners.
1) In In-Flow the handler InstanceDispatch is configured to belong to phase
PostDispatch. This phase does not exist in the current configuration.
<handler name="InstanceDispatcher"
class="org.apache.axis2.engine.InstanceDispatcher">
<order phase="PostDispatch"/>
</handler>
2) In In-Flow the handlers RequestURIBasedDispatcher and
SOAPActionBasedDispatcher belong to Transport phase, while in In-Fault-Flow
they belong to phase Dispatch. This should be consistent.
3) The usage of capital letters in phase names should be consistent. Currently
it's inflow, outflow, INfaultflow and Outfaultflow.
4) The comments that are supposed to mark which phases are pre-defined and
where developers can insert custom phases are confusing and misleading. They
also refer to phases that don't exist.
I suggest inserting comments like this:
<!-- Start system pre-defined phases -->
<phase name="X"/>
<phase name="Y"/>
<!-- End system pre-defined phases -->
<!-- Start custom phases -->
<phase name="Z"/>
<!-- End custom phases -->
or like this., respectively:
<!-- Start custom phases -->
<phase name="A"/>
<!-- End custom phases -->
<!-- Start system pre-defined phases -->
<phase name="B"/>
<phase name="C"/>
<!-- End system pre-defined phases -->
Thank you very much,
Thilo
Priority: Blocker (was: Major)
> Tidy up phase configuration in axis2.xml
> ----------------------------------------
>
> Key: AXIS2-961
> URL: http://issues.apache.org/jira/browse/AXIS2-961
> Project: Apache Axis 2.0 (Axis2)
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.0
> Reporter: Thilo Frotscher
> Priority: Blocker
>
> The current state of the phase configuration in axis2.xml is confusing,
> especially for beginners.
> 1) In In-Flow the handler InstanceDispatch is configured to belong to phase
> PostDispatch. This phase does not exist in the current configuration.
> <handler name="InstanceDispatcher"
> class="org.apache.axis2.engine.InstanceDispatcher">
> <order phase="PostDispatch"/>
> </handler>
> 2) In In-Flow the handlers RequestURIBasedDispatcher and
> SOAPActionBasedDispatcher belong to Transport phase, while in In-Fault-Flow
> they belong to phase Dispatch. This should be consistent.
> 3) The usage of capital letters in phase names should be consistent.
> Currently it's inflow, outflow, INfaultflow and Outfaultflow.
> 4) The comments that are supposed to mark which phases are pre-defined and
> where developers can insert custom phases are confusing and misleading. They
> also refer to phases that don't exist.
> I suggest inserting comments like this:
> <!-- Start system pre-defined phases -->
> <phase name="X"/>
> <phase name="Y"/>
> <!-- End system pre-defined phases -->
> <!-- Start custom phases -->
> <phase name="Z"/>
> <!-- End custom phases -->
> or like this., respectively:
> <!-- Start custom phases -->
> <phase name="A"/>
> <!-- End custom phases -->
> <!-- Start system pre-defined phases -->
> <phase name="B"/>
> <phase name="C"/>
> <!-- End system pre-defined phases -->
> Thank you very much,
> Thilo
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
