+1 but I'm confused why we'd remove this exception .. if someone sends a
response message again we should be saying "nope been there done that
already" back to the sender. If you eat the exception and log it they have
no info. What is broken about the old code?
Sanjiva.
David Illsley wrote:
Hi Brian,
I think it's important that if this (message being swallowed) is
happening, that we make it very obvous. What do you think about
logging at a higher level than debug?
David
On 28/02/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
Author: pradine
Date: Wed Feb 28 09:43:07 2007
New Revision: 512869
URL: http://svn.apache.org/viewvc?view=rev&rev=512869
Log:
Do something more useful than throw an exception.
Modified:
webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/engine/AddressingBasedDispatcher.java
Modified:
webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/engine/AddressingBasedDispatcher.java
URL:
http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/engine/AddressingBasedDispatcher.java?view=diff&rev=512869&r1=512868&r2=512869
==============================================================================
---
webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/engine/AddressingBasedDispatcher.java
(original)
+++
webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/engine/AddressingBasedDispatcher.java
Wed Feb 28 09:43:07 2007
@@ -137,16 +137,18 @@
log.debug(msgctx.getLogIDString()+"
"+Messages.getMessage("checkingrelatesto",
relatesTo));
}
- if ((relatesTo != null) && !"".equals(relatesTo)) {
+ if (relatesTo != null && !"".equals(relatesTo)) {
OperationContext operationContext =
msgctx.getConfigurationContext()
.getOperationContext(relatesTo);
if (operationContext != null) {
if(operationContext.isComplete()){
- // If the dispatch happens because of the
RelatesTo and the mep is complete
- // we should throw a more descriptive fault.
- throw new
AxisFault(Messages.getMessage("duplicaterelatesto",relatesTo));
+ if(LoggingControl.debugLoggingAllowed &&
log.isDebugEnabled()){
+ log.debug(msgctx.getLogIDString()+"
Operation context is marked as complete. Calling cleanup on it.");
+ }
+ operationContext.cleanup();
+ return InvocationResponse.CONTINUE;
}
msgctx.setAxisOperation(operationContext.getAxisOperation());
msgctx.setOperationContext(operationContext);
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
--
Sanjiva Weerawarana, Ph.D.
Founder & Director; Lanka Software Foundation; http://www.opensource.lk/
Founder, Chairman & CEO; WSO2, Inc.; http://www.wso2.com/
Director; Open Source Initiative; http://www.opensource.org/
Member; Apache Software Foundation; http://www.apache.org/
Visiting Lecturer; University of Moratuwa; http://www.cse.mrt.ac.lk/
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
