Hi all,
LOL :) Seriously, though, someone probably does need to own the
structural part (making sure that we have common utilities for getting
messages and finding resource files). The actual work of moving the
messages into resource files and changing the code should be a task that
we split up and everyone shares... ApacheCon EU's hackathon might be a
good time for this kind of thing....
We do have this framework in place. However rather than keeping
everything in one place we made i18n sections in each module so that
each module has its own lang property file (I'm guessing we probably
did that after moving out Axiom). If you look at the source trees of
the modules kernel, codegen, adb-codegen etc, the i18n package
includes the language property files.
One drawback in the way we have right now is the copying of the
resources class. I believe that each module should have its own lang
file (surely it would be impractical to maintain a huge property file
with every string used in every class in every module!) but perhaps
the resource loading class can be maintained separately in one place ?
Right now its all static.
>> 2) When generating exceptions like this, it really isn't very useful to
>> say "received some other implementation" or "value wasn't what was
>> expected". It's much more helpful to actually put the problem value
>> into the exception.... In this case it only takes an extra moment to code
>>
>> "but received " + reason.getClass() + "."
>
> 1000 appologies for this code written by me some time back. Won't happen
> again :(.
Don't take it personally (I was hoping for a ":)" instead of a ":("), we
really do have these kinds of issues everywhere and we ALL do this stuff
sometimes. I just happened to notice this a bunch of places and think
it's useful to remind ourselves of patterns.
--Glen
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
--
Ajith Ranabahu
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
