Folks:

I see a lot of this kind of thing in tests all over our source tree:

public void testSomething() {
    try {
        do something;
    } catch (Exception e) {
        e.printStackTrace();
        log.error(e.getMessage());
        fail(" An Exception has occured " + e.getMessage());
    }
}

Please don't do this. The following is much nicer and lets JUnit deal with the exceptions (which it does quite well)...

public void testSomething() throws Exception {
    do something;
}

This has been a public service announcement. We now return you to your regularly scheduled feature (or bug? :)).

--Glen

P.S. See http://www.exubero.com/junit/antipatterns.html#Catching_Unexpected_Exceptions for a little more on this.

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to