+1 to use a single convention .. I think Glen removed an incorrect use of equalsIgnoreCase in Axiom ... which is probably what's causing breakage.

I suggest going with normal camelCase.

Sanjiva.

Saminda Abeyruwan wrote:
Hi Devs,

In module.xml, the description element was written as "Description" sometimes back. Now the description element name should be written as "description" in order to get the description from AxisModule.

If you look at the addressing module.xml; it is still "Description".

Looking at the other elements that should appear in module.xml such as "InFlow", "OutFlow" have followed the Camel case convention.

Modules such as Sandesha, Rampart etc have the description element as "Description".

Why would suddenly change the description element name.


single snapshot from addressing module.xml

<module name="addressing" class="org.apache.axis2.addressing.AddressingModule"> <Description>This is WS-Addressing implementation on Axis2. Currently we have implemented Submission version (2004/08) and Proposed Recommendation.</Description>
    <InFlow>
<handler name="AddressingFinalInHandler" class="org.apache.axis2.handlers.addressing.AddressingFinalInHandler">
            <order phase="PreDispatch"/>
        </handler>
<handler name="AddressingSubmissionInHandler" class="org.apache.axis2.handlers.addressing.AddressingSubmissionInHandler">
            <order phase="PreDispatch"/>
        </handler>
<handler name="AddressingValidationHandler" class="org.apache.axis2.handlers.addressing.AddressingValidationHandler">
            <order phase="Dispatch" after="AddressingBasedDispatcher"/>
        </handler>
    </InFlow>
...
</module>


As you see some element names are following the Camel case convention and some are not. Shouldn't we need to have a single convention. {ex: Synapse configuration language format}.

As a users point of view what would be the best solution.

Thank you

Saminda

--
Saminda Abeyruwan

Software Engineer
WSO2 Inc. - www.wso2.org <http://www.wso2.org>

--
Sanjiva Weerawarana, Ph.D.
Founder & Director; Lanka Software Foundation; http://www.opensource.lk/
Founder, Chairman & CEO; WSO2, Inc.; http://www.wso2.com/
Director; Open Source Initiative; http://www.opensource.org/
Member; Apache Software Foundation; http://www.apache.org/
Visiting Lecturer; University of Moratuwa; http://www.cse.mrt.ac.lk/

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to