[
https://issues.apache.org/jira/browse/AXIS2-2749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12508712
]
Peter Danielsen commented on AXIS2-2749:
----------------------------------------
Amila,
I ran the XSLIncludeResolverTest JUnit test that I submitted on the new version
(551018) of XSLTIncludeResolver committed yesterday. Unfortunately, there were
failures. I provided the test with this JIRA to verify that my patch didn't
break any existing functionality.
The only test that failed on the original version of XSLTIncludeResolver was:
testResolveTemplateName
I expected that since it tests the new functionality that was introduced in my
patch.
All tests passed when run on the version that I submitted.
When I ran the unit test on the committed version, the following tests failed:
testResolveUnknownDataBinding
testResolveUnknownProperty
So, the committed version eliminated some existing functionality. Was this
your intent?
(To run the JUnit test on the committed version, I first restored the static
final String called EMPTY_TEMPLATE in XSLTIncludeResolver. It's used by the
JUnit test to verify the results of some tests.)
I don't understand the 26/Jun/07 comment suggesting that "externalTemplate" be
treated differently. In the templates I've seen, that configuration property
is not set and no errors occur, as far as I can tell.
One other question: Is it possible to commit the JUnit test class also? It
helps verify that the use cases it covers aren't inadvertently broken by future
changes.
Thanks for looking into this issue.
Peter
> Improved codegen XSLTIncludeResolver support for <xsl:include>
> --------------------------------------------------------------
>
> Key: AXIS2-2749
> URL: https://issues.apache.org/jira/browse/AXIS2-2749
> Project: Axis 2.0 (Axis2)
> Issue Type: Improvement
> Components: codegen
> Reporter: Peter Danielsen
> Assignee: Amila Chinthaka Suriarachchi
> Attachments: newpatch.txt, XSLTIncludeResolver.java.svn.diff,
> XSLTIncludeResolver.patch.txt, XSLTIncludeResolverTest.java,
> XSLTIncludeResolverTestTemplate.xsl
>
>
> I've been trying to create my own Axis2 codegen XSLT templates and would like
> to factor out some common templates to a separate file that can be included
> by others. An example is a template that generates a method signature. It
> would be included in a template that generates an interface and in one that
> generates an implementation class.
> The current URI resolver used by the AxisServiceBasedMultiLanguageEmitter,
> XSLTIncludeResolver, requires the value of an <xsl:include>'s href attribute
> to be a property that's in its CodeGenConfiguration object. It looks like the
> only way to set the property is to write code. It would be preferable refer
> to it directly in a template by setting the href to a value that can be
> resolved by XSLTIncludeResolver using getResourceAsStream. Such a change to
> XSLTIncludeResolver will enable easier maintenance of the existing templates,
> once refactored, and easier development of new templates since there won't be
> multiple copies of the same code to update when something changes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
