Thanks Glen,
I would like to see a diff indicating how many files are affected.
This may help determine why some files/developers are not compliant with
the formatting rules.
I agree with Jeff that the reformatting makes it difficult to produce
patches and create diffs.
Rich Scheuerle
IBM Web Services
Apache Axis2 ([EMAIL PROTECTED])
512-838-5115 (IBM TL 678-5115)
Jeff Barrett/Austin/[EMAIL PROTECTED] wrote on 07/03/2007 07:55:57 AM:
> Glen,
>
> Personally, I don't like the reformat pass idea. I think committers
> should be ensuring the code is formatted correctly when they do the
> commit. A reformat pass makes it impossible (or at least impractical) to
> do a meaningful diff against files from previous code to see what
changed,
> produce patches, revert changes, etc.
>
> I understood the need the last time because so much of the code was
> formatted inconsistently, and I'm fine with individual files being
> reformatted as necessary (as the only change in that commit).
>
> BTW - we don't all use IDEA; some of use are using Eclipse, and we have a
> preferences file that follows the coding conventions. I guess if the
> concensus is that a reformat pass is necessary, then I suggest the
> reformatting be done with a tool we can all get access to (like Eclipse).
>
> Thanks,
> Jeff
>
> IBM Software Group - WebSphere Web Services Development
> Phone: 512-838-4587 or Tie Line 678-4587
> Internet e-mail and Sametime ID: [EMAIL PROTECTED]
>
>
>
> Glen Daniels <[EMAIL PROTECTED]>
> 07/03/2007 01:21 AM
> Please respond to
> axis-dev@ws.apache.org
>
>
> To
> Axis-Dev <axis-dev@ws.apache.org>
> cc
>
> Subject
> [axis2] Reformat pass
>
>
>
>
>
>
>
> So we discussed the team using the IDEA reformatting template to clean
> and sanitize all the code immediately before each release. There were a
> bunch of +1s, but IIRC also at least one person with concerns.
>
> Shall we do this before 1.3? I can post a diff if people would like to
> see the extent of the changes. In theory, there should be no changes
> for a lot of the code since we did this back a few months ago - the
> changes would just be in new code introduced after the last reformat
> that doesn't match the style guidelines.
>
> Thoughts?
>
> --Glen
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
