"Large kiss with all"? :)
Thanks! http://svn.apache.org/viewvc?view=rev&revision=562254
-- dims
On 8/2/07, gaspode <[EMAIL PROTECTED]> wrote:
> Hi all,
>
> This mail refers to axis2 1.2.
>
> I noticed the following incorrect (IMHO) exception logging statements
> in org.apache.axis2.transport.http.AxisServlet:
>
> "
> ...
> } catch (Throwable t) {
> log.error(t);
> ...
> "
>
> (this example is from line 157, but it's representative of at least
> the rest of the class)
>
> which I think should be:
>
> "
> ...
> } catch (Throwable t) {
> log.error("bla bla bla", t);
> ...
> "
>
>
> There's quite a difference between the two: in the first place, the
> Logger's method invoked is :
>
> public void error(Object message);
>
> which will only output the exception's toString(), i.e something like this:
>
> "
> Aug 2, 2007 5:49:22 PM org.apache.axis2.transport.http.AxisServlet doPost
> SEVERE: java.lang.NoClassDefFoundError
> Aug 2, 2007 5:55:08 PM org.apache.catalina.core.StandardContext reload
> "
>
> (which is a bit disappointing...)
>
> whereas in the second case, the Logger's method called is
>
> public void error(Object message, Throwable t);
>
> so the exception is actually considered as such and the stacktrace is
> printed in the log as expected.
>
> Gros bisou à tous,
>
> Svend
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>
--
Davanum Srinivas :: http://davanum.wordpress.com
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
