Honestly, there isn't really much point to doing this change now.
Rampart already has an axis2.xml in their test repository - and people
using Axis2 and/or Rampart already have axis2.xmls in *their*
repositories. So simply changing the Rampart one will get it working
there... and explaining how to change your own will get users working.
The only thing we'd gain by doing the change in Axis2 itself now is the
ability for people picking up new SNAPSHOT releases to have Rampart work
with the default Axis2 SNAPSHOTs.
I'm planning to get the dynamic phase stuff happening over the holidays,
and the next actual release of A2 will have that functionality built in.
So if we want to spend time putting in a change which will just get
taken out, that's fine, but seems a little silly especially since the
axis2.xmls that already exist in Rampart and elsewhere are STILL going
to need to be changed anyway. Make sense?
--Glen
Sanjiva Weerawarana wrote:
+1. I suggest we do this change and when we finish the dynamic module
thing come back and clean up the module.xml files and remove any extra
phases.
That's always been the way we've done stuff .. we're not holding forward
progress while looking to some major change.
Sanjiva.
Amila Suriarachchi wrote:
On Dec 18, 2007 11:49 AM, Glen Daniels <[EMAIL PROTECTED]
<mailto:[EMAIL PROTECTED]>> wrote:
Hi Amila:
Amila Suriarachchi wrote:
> So it seems like you could get the same effect for now by
explaining in
> the Rampart documentation how to change the axis2.xml in the
correct way
> - or even including a sample.
>
> Make sense? (note I'm not saying -1, just trying to
understand)
>
> yes I got your point. But rampart trunk depends on the
Axis2-SNAPSHOT
> and they need to change the
> axis2 default xml in order to pass the test cases.
> When we do a change locally we need to commit it to the
repository soon.
> These test cases can not be committed util we change the axis2
default xml.
Hm - really? Why can't Rampart simply use a custom axis2.xml with
the
new Phase at the root of their test repository?
Then they have to update their axis2.xml when ever Axis2 does. But at
least that is how(using axis2 kernal default xml) they have done it.
Idea of keeping a axis2-SNAPSHOT dependency is to keep the rampart trunk
sync with axis2 trunk.
But I can not understand why you ask rampart people to do a big change
while they could it with a simple
axis2 change. There is no harm to axis2 with this change isn't it?
thanks,
Amila.
--Glen
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
<mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: [EMAIL PROTECTED]
<mailto:[EMAIL PROTECTED]>
--
Amila Suriarachchi,
WSO2 Inc.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]