I question the usage of the the File class's method setLastModified() in
WSInfoList.java:
private void setLastModifiedDate(File file, WSInfo wsInfo) {
if (file.isDirectory()) {
File files [] = file.listFiles();
for (int i = 0; i < files.length; i++) {
File fileItem = files[i];
if (fileItem.isDirectory()) {
setLastModifiedDate(fileItem, wsInfo);
} else {
fileItem.setLastModified(wsInfo.getLastModifiedDate());
}
}
} else {
file.setLastModified(wsInfo.getLastModifiedDate());
}
}
I do not understand why we are actually modifying the last-modified-date
of the file object? Can someone please expain this to me?
The main reason is that this causes problems when the user ID that AXIS2
is running under does not have authority to update the files. So the
attempt to modify the files will not result on anything be done (we
apparently do not check if operation failed), but more importantly, if
system auditing is enabled you will see authority-failure auditing records
for each attempt to modify the timestamp for a file. And if hotupdate is
deployed, this will result in 1000's of these records.
Possible solution: Why do we need to test for equality when looking at
time-stamps? We can save the new'est last-modified time stampt, and then
when we want to detect if something has changed, we simply see if the
saved-timestamp is greater or equal to the file-timestamp. And if this is
true, then the file has not changed. Otherwise, the file has
changed.....the added benefit is we do not have to update files.
I would like to get this in for 1.4 if possible so please respond as soon
as possible. If I do not hear from anyone in the next 2-3 days, I will
open a jira and implement a new solution.
Nadir Amra
Integrated Web services for i5/OS
IBM Rochester, MN, (Tel. 507-253-0645, t/l 553-0645)
Internet: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
