Forgot the patch :-( sorry...
Ruwan
On Mon, Apr 21, 2008 at 8:12 PM, Ruwan Linton <[EMAIL PROTECTED]>
wrote:
> Hi Dims,
>
> It seems that the PhaseRuleTests.java is not running with the tests, so I
> have added this testcase to the PreDispatchPhaseRuleTest.java and here
> attach with is the patch to the test.
>
> Due to this issue phaseLast="true" also doesn't work properly, (if you
> specify any handler to be after a particular handler in that phase, then
> that handler will be added after the phaseLast handler) and the second
> addition causes this error.
>
> Hope this will be fixed on the axis2-1.4
>
> Thanks,
> Ruwan
>
>
> On Mon, Apr 21, 2008 at 5:34 PM, Davanum Srinivas <[EMAIL PROTECTED]>
> wrote:
>
> > Ah. ok. that makes me feel slightly better. Please add the test here.
> >
> > modules\kernel\test\org\apache\axis2\phaserule\PhaseRuleTests.java
> >
> > -- dims
> >
> >
> >
> > On Mon, Apr 21, 2008 at 7:36 AM, Ruwan Linton <[EMAIL PROTECTED]>
> > wrote:
> > > Dims,
> > >
> > > Well we did track the axis2 trunk, but till rampart folks added this
> > handler
> > > with phaseLast set to true we couldn't find the issue.
> > >
> > > As far as I can see, without this fix there is no meaning of the after
> > > attribute of the handlers in a module.xml
> > >
> > > Thanks,
> > > Ruwan
> > >
> > >
> > >
> > > On Mon, Apr 21, 2008 at 5:02 PM, Davanum Srinivas <[EMAIL PROTECTED]>
> > wrote:
> > > > Deepal,
> > > >
> > > > Am afraid at making this change so late in the game..after 5 RC's.
> > > > From what i recall, The phase code is so sensitive to JDK's. Can
> > > > Synapse guys ship this class with their other axis2 classes?
> > > >
> > > > thanks,
> > > > dims
> > > >
> > > > PS: Wish Syanpse trunk tracked Axis2 trunk. That would have avoided
> > > > this issue entirely. But that would be asking for too much i guess..
> > > >
> > > >
> > > >
> > > >
> > > > On Mon, Apr 21, 2008 at 6:42 AM, Deepal jayasinghe <
> > [EMAIL PROTECTED]>
> > > wrote:
> > > > > Hi Dims,
> > > > >
> > > > > I have attached a patch for
> > > > > https://issues.apache.org/jira/browse/SYNAPSE-271 , which I
> > consider as
> > > > > critical for them. If you can please go though that and try to
> > apply to
> > > the
> > > > > branch.
> > > > >
> > > > > Thank you!
> > > > > Deepal
> > > > >
> > > > >
> > > > > > Folks,
> > > > > >
> > > > > > Jarek (many thanks!) ran the JAXWS 2.1 TCK a little while ago
> > and
> > > > > everything looks good. Please don't check into 1.4
> > > > > > branch till further notice.
> > > > > >
> > > > > > If you need something to get into 1.4 Final, please submit a
> > diff
> > > against
> > > > > the branch and raise a JIRA with fix version
> > > > > > to 1.4 and priority as blocker.
> > > > > >
> > > > > > Thanks,
> > > > > > dims
> > > > > >
> > > > > > PS: Please remember there's a code freeze on
> > axiom/xmlschema/neethi
> > > > > trunk(s) as well.
> > > > > >
> > > > >
> > > > >
> > > > >
> > ---------------------------------------------------------------------
> > > > > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > > > > For additional commands, e-mail: [EMAIL PROTECTED]
> > > > >
> > > > >
> > > >
> > > >
> > > >
> > > > --
> > > > Davanum Srinivas :: http://davanum.wordpress.com
> > > >
> > > >
> > > >
> > > >
> > > >
> > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > > > For additional commands, e-mail: [EMAIL PROTECTED]
> > > >
> > > >
> > >
> > >
> > >
> > > --
> > >
> > > Ruwan Linton
> > > http://www.wso2.org - "Oxygenating the Web Services Platform"
> >
> >
> >
> > --
> > Davanum Srinivas :: http://davanum.wordpress.com
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > For additional commands, e-mail: [EMAIL PROTECTED]
> >
> >
>
>
> --
> Ruwan Linton
> http://www.wso2.org - "Oxygenating the Web Services Platform"
>
--
Ruwan Linton
http://www.wso2.org - "Oxygenating the Web Services Platform"
Index: test/org/apache/axis2/phaserule/PreDispatchPhaseRuleTest.java
===================================================================
--- test/org/apache/axis2/phaserule/PreDispatchPhaseRuleTest.java (revision 650124)
+++ test/org/apache/axis2/phaserule/PreDispatchPhaseRuleTest.java (working copy)
@@ -121,4 +121,56 @@
System.out.println("Name:" + metadata.getName().getLocalPart());
}*/
}
+
+ public void testPhaseLastAndAfter() throws Exception {
+
+ Phase phase = new Phase();
+
+ //////////////// handler 1 //////////////////////////
+ PhaseRuleHandler h1 = new PhaseRuleHandler("a");
+ HandlerDescription hd1 = new HandlerDescription("a");
+ h1.init(hd1);
+ hd1.setHandler(h1);
+ phase.addHandler(hd1);
+ /////////////////////////////////////////////////////
+
+ //////////////// handler 4 //////////////////////////
+ PhaseRule rule4 = new PhaseRule();
+ rule4.setPhaseLast(true);
+
+ PhaseRuleHandler h4 = new PhaseRuleHandler("d");
+ HandlerDescription hd4 = new HandlerDescription("d");
+ h4.init(hd4);
+
+ hd4.setHandler(h4);
+ hd4.setRules(rule4);
+ phase.addHandler(hd4);
+ ////////////////////////////////////////////////////
+
+ //////////////// handler 2 //////////////////////////
+ PhaseRule rule2 = new PhaseRule();
+ rule2.setAfter("a");
+
+ HandlerDescription hd2 = new HandlerDescription("b");
+ PhaseRuleHandler h2 = new PhaseRuleHandler("b");
+ h2.init(hd2);
+
+ hd2.setHandler(h2);
+ hd2.setRules(rule2);
+ phase.addHandler(hd2);
+ //////////////////////////////////////////////////////
+
+ //////////////// handler 3 //////////////////////////
+ PhaseRule rule3 = new PhaseRule();
+ rule3.setAfter("b");
+
+ HandlerDescription hd3 = new HandlerDescription("c");
+ PhaseRuleHandler h3 = new PhaseRuleHandler("c");
+ h3.init(hd3);
+
+ hd3.setHandler(h3);
+ hd3.setRules(rule3);
+ phase.addHandler(hd3);
+ //////////////////////////////////////////////////////
+ }
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
