[
https://issues.apache.org/jira/browse/AXIS2-3964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12640186#action_12640186
]
aandrade edited comment on AXIS2-3964 at 10/16/08 12:24 PM:
-------------------------------------------------------------------
Submitting patch for Review:
Saving AxisBindingOperation children using the corresponding message label as
key (as described in the bug's description). Note that since the message label
depends on the message direction AND this (the direction) depends on the
'isServerSide' flag, the retrieval of the proper AxisMessage was also updated
both for HTTP and SOAP bindings processing. This, by itself, was a separate
issue.
Other: I think that the 'isServerSide' flag usage should be reviewed and a
general refactoring should be considered. i.e. There should probably be methods
defined in the WSDLToAxisServiceBuilder that deal with the retrieval of
isServerSide-sensitive information (messages based on directions, labels, etc)
in a more consistent way. The usage of this flag has caused a lot of
duplication of code.
was (Author: aandrade):
Saving AxisBindingOperation children using the corresponding message label
as key (as described in the bug's description). Note that since the message
label depends on the message direction AND this (the direction) depends on the
'isServerSide' flag, the retrieval of the proper AxisMessage was also updated
both for HTTP and SOAP bindings processing. This, by itself, was a separate
issue.
Other: I think that the 'isServerSide' flag usage should be reviewed and a
general refactoring should be considered. i.e. There should probably be methods
defined in the WSDLToAxisServiceBuilder that deal with the retrieval of
isServerSide-sensitive information (messages based on directions, labels, etc)
in a more consistent way. The usage of this flag has caused a lot of
duplication of code.
> WSDL20ToAxisServiceBuilder > HTTP Binding: AxisBindingMessage entry is being
> overwritten in corresponding AxisBindingOperation
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: AXIS2-3964
> URL: https://issues.apache.org/jira/browse/AXIS2-3964
> Project: Axis 2.0 (Axis2)
> Issue Type: Bug
> Components: kernel
> Affects Versions: 1.4, nightly
> Environment: Windows XP. 4GB RAM Intel Xeon dual-core @2.75Ghz
> Reporter: Antonio Andrade
> Assignee: Keith Godwin Chapman
> Priority: Minor
> Attachments: AXIS2-3964.patch
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> Observed Behavior:
> Within WSDL20ToAxisServiceBuilder, AxisBindingOperation children are always
> saved under the WSDLConstants.MESSAGE_LABEL_IN_VALUE key when the HTTP
> Binding is used. Look at processHTTPBindingExtention method (around line 921).
> Expected Behavior:
> When using the HTTP Binding, AxisBindingMessages should be saved under the
> corresponding key (should be correctly set into the corresponding
> AxisBindingOperation):
> - WSDLConstants.MESSAGE_LABEL_IN_VALUE whenever the message has a
> WSDLConstants.WSDL_MESSAGE_DIRECTION_IN direction
> - WSDLConstants.MESSAGE_LABEL_OUT_VALUE whenever the message has a
> WSDLConstants.WSDL_MESSAGE_DIRECTION_OUT direction
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
