+1 - the transport handling code should be independent of the format of the data that flows on that transport, which is what MessageBuilder and MessageFormatter objects take care of. However, in the case of Stomp, is the transport a raw TCP stream with the binary bits? If so separation of message formatter etc. is not sensible - the transport itself can do everything and return a message context as you noted.
Sanjva. On Sat, Jan 2, 2010 at 12:01 AM, Andreas Veithen <andreas.veit...@gmail.com>wrote: > Dunith, > > You are entirely right. A transport is not supposed to implement > message builders and formatters, but only to use (as much as possible) > these APIs to support various payload formats. Probably that is what > Thilina wanted to say, but his post was not very clear. > > Andreas > > On Wed, Dec 30, 2009 at 05:13, Dunith Dhanushka <duni...@gmail.com> wrote: > > Hi folks, > > > > Many thanks in advance for your feedback Thilina. > > > > I considered Thilina's point before starting the design process and at > that > > moment, I have no idea about MessageFormaters and MessageBuilders. > > I was looking for a methodology that can be applied to mix & match > message > > formats irrespective of the transport based on the content type.I > examined > > several transports like JMS,XMPP and HTTP in Axis2 earlier versions and I > > couldn't find seperate classes for MessageBuilder and MessageFormater. > > Instead they all used a method like > > > > -createMessageContext(<External data packet from the other format>) > returns > > MessageContext > > > > to populate the MessageContext from the protocol specific data > > packet(PDU). > > > > So I decided to implement a such method inside the StompPacketListener > and > > it will read the incoming stomp packet,extract the content and finally > > creates a MessageContext with a SOAPEnvelope that is independent of the > > transport protocol. > > > > I'll be submitting the patch tomorrow because I have to test it against a > > Stomp implementation other than Apache ActiveMq. > > > > Folks, I wish you a happy new year with peace and prosperity... > > > > regards, > > Dunith Dhanushka > > > -- Sanjiva Weerawarana, Ph.D. Founder, Director & Chief Scientist; Lanka Software Foundation; http://www.opensource.lk/ Founder, Chairman & CEO; WSO2, Inc.; http://www.wso2.com/ Member; Apache Software Foundation; http://www.apache.org/ Visiting Lecturer; University of Moratuwa; http://www.cse.mrt.ac.lk/ Blog: http://sanjiva.weerawarana.org/
