All,

Starting with version 1.2 of the antrun plugin, it is possible to
conditionally skip ant executions based on system properties. What
Ruwan is looking for can thus be achieved using the following syntax:

<tasks unless="maven.test.skip">

I changed the POMs (see r904780 and AXIS2-3290) to use that approach
and tested the build successfully in the following scenarios:

* mvn clean install: behaves as usual
* mvn clean install -Dtest=false: behaves as usual
* mvn clean install -Dmaven.test.skip=true: this now effectively skips
test compilation (including ant scripts) and execution

If anyone encounters any problems or discovers any side effects that I
didn't see, please revert the change (svn merge -c -904780 . .) and
let me know so that I can investigate the issue.

Andreas

On Thu, Jan 28, 2010 at 04:43, Ruwan Linton <ruwan.lin...@gmail.com> wrote:
> Hi Andreas and all,
>
> I sort of figured out the issue, this occurs when you skip tests using the
> maven.test.skip system property. According to the maven documentation
> maven.test.skip system property not only by passes running tests but also by
> passes compiling tests as well.
>
> In this particular case, if the tests are not compiled, the build will be
> failing because at the tes-compile phase, the ant-run plugin tries to create
> a service archive out those compiled test classes, which is failing. Note
> that, even though the above property by-passes compiling tests, it does not
> by-pass the maven phase. (There is no way to by-pass phases in maven, AFAIK)
>
> Then I tried to put this ant task bit into a profile and tried to activate
> it only when the tests are enabled, but maven doesn't seem to give me an
> option to check whether the tests are enabled or not. Though I can track the
> test disabled scenario, I cannot track the test enabled scenario.
>
> As the last option I tried to use the file based profile activation, to see
> the compiled test classes exists or not to activate the ant task. This
> approach also failed, since maven decides the activated profile at the start
> of the execution at which point the file exists decision is wrong, ideally
> if the profile activation decision should have been taken at the desired
> phase, but I think there are technical limitations for maven to do so.
>
> So with the above analysis I couldn't get this solved, but fortunately maven
> has an option to ask not to run the tests, but let it compile the tests,
> using the system property called "skipTests".
>
> So the conclusion is use;
>
> mvn clean install -DskipTests
>
> instead of "mvn clean install -Dmaven.test.skip=true" if you want to skip
> axis2 build tests.
>
> Thanks,
> Ruwan
>
> On Thu, Jan 28, 2010 at 1:00 AM, Andreas Veithen <andreas.veit...@gmail.com>
> wrote:
>>
>> For the moment I don't have any idea how to debug this. I was going to
>> suggest setting the verbose option to true on the
>> maven-compiler-plugin, but that doesn't seem to work.
>>
>> Andreas
>>
>> On Tue, Jan 26, 2010 at 02:40, Ruwan Linton <ruwan.lin...@gmail.com>
>> wrote:
>> > Also, it is getting compiled when you run maven on the jaxws-integration
>> > module, but not compiling when running on the axis2 build root :-(
>> >
>> > Any clue??
>> >
>> > Thanks,
>> > Ruwan
>> >
>> > On Tue, Jan 26, 2010 at 7:38 AM, Ruwan Linton <ruwan.lin...@gmail.com>
>> > wrote:
>> >>
>> >> Andreas,
>> >>
>> >> I drilled down the problem to not compiling the following test packages
>> >> of
>> >> jaxws-integration module on my machine;
>> >>
>> >> org.apache.axis2.jaxws.type_substitution
>> >>
>> >> Because of this the classes that are required for the
>> >> AppleFinderService
>> >> creating ant task is missing and cause the above error. I wonder
>> >> whether the
>> >> '_' character in the package name causes this issue.
>> >>
>> >> Trying to resolve the issue.
>> >>
>> >> Thanks,
>> >> Ruwan
>> >>
>> >> On Tue, Jan 26, 2010 at 3:29 AM, Andreas Veithen
>> >> <andreas.veit...@gmail.com> wrote:
>> >>>
>> >>> Ruwan,
>> >>>
>> >>> I just tested with the following combination, which is very close to
>> >>> what you have (except for the OS):
>> >>>
>> >>> Apache Maven 2.2.1 (r801777; 2009-08-06 21:16:01+0200)
>> >>> Java version: 1.6.0_17
>> >>> Java home:
>> >>> /System/Library/Frameworks/JavaVM.framework/Versions/1.6.0/Home
>> >>> Default locale: en_US, platform encoding: MacRoman
>> >>> OS name: "mac os x" version: "10.5.8" arch: "x86_64" Family: "mac"
>> >>>
>> >>> Result: the build succeeds without any problems, so we still have no
>> >>> clue what causes this issue.
>> >>>
>> >>> Andreas
>> >>>
>> >>> On Mon, Jan 25, 2010 at 17:37, Ruwan Linton <ruwan.lin...@gmail.com>
>> >>> wrote:
>> >>> >
>> >>> >
>> >>> > On Mon, Jan 25, 2010 at 9:03 PM, Andreas Veithen
>> >>> > <andreas.veit...@gmail.com>
>> >>> > wrote:
>> >>> >>
>> >>> >> On Mon, Jan 25, 2010 at 15:30, Ruwan Linton
>> >>> >> <ruwan.lin...@gmail.com>
>> >>> >> wrote:
>> >>> >> > Andreas,
>> >>> >> >
>> >>> >> > I don't have maven 2.0 right now to test this, but I was having
>> >>> >> > this
>> >>> >> > issue
>> >>> >> > with maven 2.1.0 and JDK 1.5 as well. Does this means that you
>> >>> >> > are
>> >>> >> > not
>> >>> >> > getting this failure on maven 2.0 and JDK 1.5??
>> >>> >>
>> >>> >> I've never seen the AppleFinderService failure myself, and I use
>> >>> >> Maven
>> >>> >> 2.0 with JDK 1.5. Searching the mailing list archives for
>> >>> >> "AppleFinderService" indicates that the issue only occurs in
>> >>> >> particular build environments, since for most people the build just
>> >>> >> runs fine.
>> >>> >>
>> >>> >> > Anyway if this is failing on at least one environment we should
>> >>> >> > get
>> >>> >> > that
>> >>> >> > fixed.
>> >>> >>
>> >>> >> +1, but to be able to fix it, we first need to reproduce it. If I
>> >>> >> get
>> >>> >> the time later today, I will try the build with Maven 2.2 and JDK
>> >>> >> 1.6.
>> >>> >
>> >>> > Thanks, at the same time I am trying to fix it at my end too.
>> >>> >
>> >>> > Ruwan
>> >>> >
>> >>> >>
>> >>> >> > Thanks,
>> >>> >> > Ruwan
>> >>> >> >
>> >>> >> > On Mon, Jan 25, 2010 at 2:30 PM, Andreas Veithen
>> >>> >> > <andreas.veit...@gmail.com>
>> >>> >> > wrote:
>> >>> >> >>
>> >>> >> >> It is a known issue in the sense that several people complained
>> >>> >> >> about
>> >>> >> >> it, but AFAIK until now, nobody ever provided detailed
>> >>> >> >> information
>> >>> >> >> about it. Do you also experience that failure with Maven 2.0 and
>> >>> >> >> JDK
>> >>> >> >> 1.5?
>> >>> >> >>
>> >>> >> >> Andreas
>> >>> >> >>
>> >>> >> >> On Mon, Jan 25, 2010 at 03:47, Ruwan Linton
>> >>> >> >> <ruwan.lin...@gmail.com>
>> >>> >> >> wrote:
>> >>> >> >> > Folks,
>> >>> >> >> >
>> >>> >> >> > I cannot do a "mvn clean install" on the root of the axis2
>> >>> >> >> > build,
>> >>> >> >> > which
>> >>> >> >> > blames me for a missing AppleFinderService. Is this a known
>> >>> >> >> > issue, if
>> >>> >> >> > so
>> >>> >> >> > why
>> >>> >> >> > don't we get this fixed.
>> >>> >> >> >
>> >>> >> >> > My build environment is;
>> >>> >> >> > mvn --version
>> >>> >> >> > Apache Maven 2.2.1 (r801777; 2009-08-07 01:16:01+0600)
>> >>> >> >> > Java version: 1.6.0_18
>> >>> >> >> > Java home: /opt/jdk1.6.0_18/jre
>> >>> >> >> > Default locale: en_US, platform encoding: UTF-8
>> >>> >> >> > OS name: "linux" version: "2.6.31-17-generic" arch: "amd64"
>> >>> >> >> > Family:
>> >>> >> >> > "unix"
>> >>> >> >> >
>> >>> >> >> > Thanks,
>> >>> >> >> > Ruwan
>> >>> >> >> >
>> >>> >> >> > --
>> >>> >> >> > Ruwan Linton
>> >>> >> >> > Technical Lead & Product Manager; WSO2 ESB;
>> >>> >> >> > http://wso2.org/esb
>> >>> >> >> > WSO2 Inc.; http://wso2.org
>> >>> >> >> > email: ru...@wso2.com; cell: +94 77 341 3097
>> >>> >> >> > blog: http://ruwansblog.blogspot.com
>> >>> >> >> >
>> >>> >> >
>> >>> >> >
>> >>> >> >
>> >>> >> > --
>> >>> >> > Ruwan Linton
>> >>> >> > Technical Lead & Product Manager; WSO2 ESB; http://wso2.org/esb
>> >>> >> > WSO2 Inc.; http://wso2.org
>> >>> >> > email: ru...@wso2.com; cell: +94 77 341 3097
>> >>> >> > blog: http://ruwansblog.blogspot.com
>> >>> >> >
>> >>> >
>> >>> >
>> >>> >
>> >>> > --
>> >>> > Ruwan Linton
>> >>> > Technical Lead & Product Manager; WSO2 ESB; http://wso2.org/esb
>> >>> > WSO2 Inc.; http://wso2.org
>> >>> > email: ru...@wso2.com; cell: +94 77 341 3097
>> >>> > blog: http://ruwansblog.blogspot.com
>> >>> >
>> >>
>> >>
>> >>
>> >> --
>> >> Ruwan Linton
>> >> Technical Lead & Product Manager; WSO2 ESB; http://wso2.org/esb
>> >> WSO2 Inc.; http://wso2.org
>> >> email: ru...@wso2.com; cell: +94 77 341 3097
>> >> blog: http://ruwansblog.blogspot.com
>> >
>> >
>> >
>> > --
>> > Ruwan Linton
>> > Technical Lead & Product Manager; WSO2 ESB; http://wso2.org/esb
>> > WSO2 Inc.; http://wso2.org
>> > email: ru...@wso2.com; cell: +94 77 341 3097
>> > blog: http://ruwansblog.blogspot.com
>> >
>
>
>
> --
> Ruwan Linton
> Technical Lead & Product Manager; WSO2 ESB; http://wso2.org/esb
> WSO2 Inc.; http://wso2.org
> email: ru...@wso2.com; cell: +94 77 341 3097
> blog: http://ruwansblog.blogspot.com
>

Reply via email to