+1
These changes look good. I am a bit dubious about checking the comments for System.out.println's, but it might catch some cruft that shouldn't be checked in. -- Tom Jordahl -----Original Message----- From: Richard Sitze [mailto:[EMAIL PROTECTED]] Sent: Wednesday, February 20, 2002 12:28 PM To: [EMAIL PROTECTED] Subject: [AXIS - PATCH] More logging changes Some of these may be more controversial, so I'd appreciate a review by interested parties before anyone applies the patch (diff -u, right?). (See attached file: diffs.txt) Summary of changes: 0. Everyone needs to learn how to edit/override log4j.properties rather than writing code with System.out.println.... The tests will fail for most such code. 1. New jar file, only needed for test (doesn't need to be distributed). to be added in new directory test/lib: (See attached file: jakarta-oro-2.0.5.jar) 2. test/utils/TestSrcContent.java is a "check-in" test that verifies aspects of the source code. It has been changed to use a list of triplets: regex (Perl5) filename, regex file-content, and content-match flag (should or shouldn't be in file...). Matching names and content generate an error. It currently looks for: - direct use of log4j (error) - use of System.out.println or System.err.println. Eexceptions are AxisFault.java, Version.java, client/AdminClient.java, providers/BSFProvider.java, utils.tcpmon.java, and all tooling in wsdl. 3. Outside of the listed exceptions, I've removed use of System.out.println or System.err.println and replaced with log.info, log.debug, or log.error as seemed appropriate (thereby allowing test to pass :-). 4. To facilitate output that USE to appear, I've changed the log4j properties file to allow INFO, ERROR, and FATAL log messages to be dumped to the console.... of course we see even more now. ******************************************* Richard A. Sitze [EMAIL PROTECTED] CORBA Interoperability & WebServices IBM WebSphere Development
