butek 02/03/06 12:34:17
Modified: java/src/org/apache/axis SimpleChain.java
java/src/org/apache/axis/client AxisClient.java Call.java
Log:
I got rid of some of the ignorable exceptions from the functional-tests. I only went
after the biggest offender - the multithread test - but this sort of fix should be
done
everywhere. Here's the philosophy I followed:
- if a catch block is rethrowing the exception, don't log it (it will probably be
logged
elsewhere)
- if a catch block throws a different exception, log the original, but log it as
debug, not
error; this bit of code is in error, but somebody higher up the call chain may
handle it,
in which case it is NOT an error.
This is a change in philosophy that we might want to discuss.
Revision Changes Path
1.43 +0 -2 xml-axis/java/src/org/apache/axis/SimpleChain.java
Index: SimpleChain.java
===================================================================
RCS file: /home/cvs/xml-axis/java/src/org/apache/axis/SimpleChain.java,v
retrieving revision 1.42
retrieving revision 1.43
diff -u -r1.42 -r1.43
--- SimpleChain.java 25 Feb 2002 17:38:14 -0000 1.42
+++ SimpleChain.java 6 Mar 2002 20:34:17 -0000 1.43
@@ -155,8 +155,6 @@
i++;
}
} catch( AxisFault f ) {
- // notify fault in reverse order and then rethrow
- log.error( JavaUtils.getMessage("axisFault00"), f );
while( --i >= 0 )
((Handler) handlers.elementAt( i )).onFault( msgContext );
throw f;
1.41 +1 -1 xml-axis/java/src/org/apache/axis/client/AxisClient.java
Index: AxisClient.java
===================================================================
RCS file: /home/cvs/xml-axis/java/src/org/apache/axis/client/AxisClient.java,v
retrieving revision 1.40
retrieving revision 1.41
diff -u -r1.40 -r1.41
--- AxisClient.java 25 Feb 2002 17:38:14 -0000 1.40
+++ AxisClient.java 6 Mar 2002 20:34:17 -0000 1.41
@@ -193,7 +193,7 @@
} catch( Exception e ) {
// Should we even bother catching it ?
- log.error(JavaUtils.getMessage("exception00"), e);
+ log.debug(JavaUtils.getMessage("exception00"), e);
throw AxisFault.makeFault(e);
} finally {
1.89 +1 -1 xml-axis/java/src/org/apache/axis/client/Call.java
Index: Call.java
===================================================================
RCS file: /home/cvs/xml-axis/java/src/org/apache/axis/client/Call.java,v
retrieving revision 1.88
retrieving revision 1.89
diff -u -r1.88 -r1.89
--- Call.java 6 Mar 2002 12:50:06 -0000 1.88
+++ Call.java 6 Mar 2002 20:34:17 -0000 1.89
@@ -1524,7 +1524,7 @@
invoke();
}
catch( Exception e ) {
- log.error( JavaUtils.getMessage("exception00"), e );
+ log.debug( JavaUtils.getMessage("exception00"), e );
throw AxisFault.makeFault(e);
}
