butek 02/03/06 15:39:17
Modified: java/src/org/apache/axis/handlers JWSProcessor.java
java/src/org/apache/axis/providers/java JavaProvider.java
java/src/org/apache/axis/transport/http
SimpleAxisServer.java
Log:
I got rid of the rest of the ignorable exceptions from the functional-tests. Here's
the
philosophy I followed:
- if a catch block is rethrowing the exception, don't log it (it will probably be
logged
elsewhere)
- if a catch block throws a different exception, log the original, but log it as
debug, not
error; this bit of code is in error, but somebody higher up the call chain may
handle it,
in which case it is NOT an error.
The toughest choice was following this philosophy on SimpleAxisServer, but since
the exceptions there are being bundled to go across the wire, I still feel changing
from log.error to log.debug is the right thing to do. The outermost catch block, in
main, I left as log.error because if the code gets there execution ceases.
The important thing is that the functional tests are back to being clean again.
Revision Changes Path
1.42 +1 -1 xml-axis/java/src/org/apache/axis/handlers/JWSProcessor.java
Index: JWSProcessor.java
===================================================================
RCS file: /home/cvs/xml-axis/java/src/org/apache/axis/handlers/JWSProcessor.java,v
retrieving revision 1.41
retrieving revision 1.42
diff -u -r1.41 -r1.42
--- JWSProcessor.java 25 Feb 2002 17:38:15 -0000 1.41
+++ JWSProcessor.java 6 Mar 2002 23:39:17 -0000 1.42
@@ -283,7 +283,7 @@
rpc.cleanup(); // ??
}
catch( Exception e ) {
- log.error( JavaUtils.getMessage("exception00"), e );
+ log.debug( JavaUtils.getMessage("exception00"), e );
throw AxisFault.makeFault(e);
}
1.42 +1 -1
xml-axis/java/src/org/apache/axis/providers/java/JavaProvider.java
Index: JavaProvider.java
===================================================================
RCS file:
/home/cvs/xml-axis/java/src/org/apache/axis/providers/java/JavaProvider.java,v
retrieving revision 1.41
retrieving revision 1.42
diff -u -r1.41 -r1.42
--- JavaProvider.java 25 Feb 2002 17:38:16 -0000 1.41
+++ JavaProvider.java 6 Mar 2002 23:39:17 -0000 1.42
@@ -258,7 +258,7 @@
resEnv, jc, obj);
}
catch( Exception exp ) {
- log.error( JavaUtils.getMessage("exception00"), exp );
+ log.debug( JavaUtils.getMessage("exception00"), exp );
throw AxisFault.makeFault(exp);
}
if (log.isDebugEnabled())
1.55 +2 -2
xml-axis/java/src/org/apache/axis/transport/http/SimpleAxisServer.java
Index: SimpleAxisServer.java
===================================================================
RCS file:
/home/cvs/xml-axis/java/src/org/apache/axis/transport/http/SimpleAxisServer.java,v
retrieving revision 1.54
retrieving revision 1.55
diff -u -r1.54 -r1.55
--- SimpleAxisServer.java 6 Mar 2002 13:54:59 -0000 1.54
+++ SimpleAxisServer.java 6 Mar 2002 23:39:17 -0000 1.55
@@ -394,7 +394,7 @@
AxisFault af;
if (e instanceof AxisFault) {
af = (AxisFault)e;
- log.error(JavaUtils.getMessage("serverFault00"), af);
+ log.debug(JavaUtils.getMessage("serverFault00"), af);
if ("Server.Unauthorized".equals(af.getFaultCode())) {
status = UNAUTH; // SC_UNAUTHORIZED
@@ -459,7 +459,7 @@
} catch (InterruptedIOException iie) {
break;
} catch (Exception e) {
- log.error(JavaUtils.getMessage("exception00"), e);
+ log.debug(JavaUtils.getMessage("exception00"), e);
} finally {
try {
if (socket!=null) socket.close();
