+1 on fixing the build
+1 on keeping WSDD (deployment info) free from static information
particular to the
application to be deployed. By default or otherwise... IMHO, the
WSDL describes
"what" to deploy, the WSDD describes "how" to deply, and we
shouldn't mix the two up!
+1 on design discussions and votes before making significant changes,
regardless
of the requirement (bug fix or other) driving the change!
*******************************************
Richard A. Sitze [EMAIL PROTECTED]
CORBA Interoperability & WebServices
IBM WebSphere Development
Russell
Butek/Austin/IBM To: [EMAIL PROTECTED]
@IBMUS cc:
Subject: RE: Got rid of skeletons?
(was: cvs
03/28/2002 11:55 commit: xml-axis/java/test/
wsdl/multibinding
AM VerifyFilesTestCase.java)
Please respond
to axis-dev
I think we need a vote on this. But before we even vote, you should be
aware that your changes broke the roundtripping tests. Unfortunately the
functional-tests succeed because the roundtrip failure is a compile failure
and we decided a while ago to continue from compile failures. The failure
is:
[copy] Copying 9 files to C:
\xml-axis\java\build\work\test\wsdl\roundtrip
[javac] Compiling 9 source files to C:\xml-axis\java\build\classes
[java2wsdl] Java2WSDL test.wsdl.roundtrip.RoundtripPortType
[delete] Deleting directory C:
\xml-axis\java\build\classes\test\wsdl\roundtrip
[wsdl2java] WSDL2Java build/work/test/wsdl/roundtrip/Roundtrip.wsdl
[wsdl2java] WSDL2Java test/wsdl/sequence/SequenceTest.wsdl
[copy] Copying 1 file to C:
\xml-axis\java\build\work\test\wsdl\sequence
[javac] Compiling 5 source files to C:\xml-axis\java\build\classes
[java2wsdl] Java2WSDL test.wsdl.sequence.SequenceTestPortType
[java2wsdl] java.lang.ClassNotFoundException:
test.wsdl.sequence.SequenceTestSoapBindingSkeleton
[java2wsdl] at
org.apache.tools.ant.AntClassLoader.findClassInComponents(AntClassLoader.java:925)
[java2wsdl] at
org.apache.tools.ant.AntClassLoader.findClass(AntClassLoader.java:898)
[java2wsdl] at
org.apache.tools.ant.AntClassLoader.loadClass(AntClassLoader.java:795)
[java2wsdl] at java.lang.ClassLoader.loadClass(ClassLoader.java:255)
[java2wsdl] at
java.lang.ClassLoader.loadClassInternal(ClassLoader.java:315)
[java2wsdl] at java.lang.Class.forName0(Native Method)
[java2wsdl] at java.lang.Class.forName(Class.java:120)
[java2wsdl] at
org.apache.axis.wsdl.fromJava.Emitter.setImplCls(Unknown Source)
[java2wsdl] at test.wsdl.Java2WsdlAntTask.execute(Unknown Source)
[java2wsdl] at org.apache.tools.ant.Task.perform(Task.java:217)
[java2wsdl] at org.apache.tools.ant.Target.execute(Target.java:184)
[java2wsdl] at
org.apache.tools.ant.Target.performTasks(Target.java:202)
[java2wsdl] at
org.apache.tools.ant.Project.executeTarget(Project.java:601)
[java2wsdl] at
org.apache.tools.ant.taskdefs.Ant.execute(Ant.java:266)
[java2wsdl] at org.apache.tools.ant.Task.perform(Task.java:217)
[java2wsdl] at org.apache.tools.ant.Target.execute(Target.java:184)
[java2wsdl] at
org.apache.tools.ant.Target.performTasks(Target.java:202)
[java2wsdl] at
org.apache.tools.ant.Project.executeTarget(Project.java:601)
[java2wsdl] at
org.apache.tools.ant.taskdefs.Ant.execute(Ant.java:266)
[java2wsdl] at org.apache.tools.ant.Task.perform(Task.java:217)
[java2wsdl] at org.apache.tools.ant.Target.execute(Target.java:184)
[java2wsdl] at
org.apache.tools.ant.Target.performTasks(Target.java:202)
[java2wsdl] at
org.apache.tools.ant.Project.executeTarget(Project.java:601)
[java2wsdl] at
org.apache.tools.ant.Project.executeTargets(Project.java:560)
[java2wsdl] at org.apache.tools.ant.Main.runBuild(Main.java:454)
[java2wsdl] at org.apache.tools.ant.Main.start(Main.java:153)
[java2wsdl] at org.apache.tools.ant.Main.main(Main.java:176)
[delete] Deleting directory C:
\xml-axis\java\build\classes\test\wsdl\sequence
Note that there are similar failures for many of the interop3 tests.
So the first step, before we even consider a vote, is to fix the runtime
(not the tests!) so that they compile again.
You're putting stuff that used to be in the skeleton into the deploy.wsdd.
I've already mentioned to you that I disagree with your putting metadata
into the deploy.wsdd file. We at IBM have a different deploy mechanism and
we don't believe metadata belongs in the DD. We were very happy with that
info in the skeleton. Perhaps we can remodel the -S flag on WSDL2Java
- -S false means: don't emit a skeleton, refer to the impl in the
deploy.wsdd and, since the metadata isn't elsewhere, put the metadata in
the deploy.wsdd
- -S true means: emit a skeleton, refer to the skeleton in the
deploy.wsdd, but since the skeleton has the metadata, don't bother putting
it in the deploy.wsdd.
I still think generating the skeleton should be the default, but that can
be one of the things we vote on once you fix the build.
Russell Butek
[EMAIL PROTECTED]
Glen Daniels <[EMAIL PROTECTED]> on 03/28/2002 11:14:28 AM
Please respond to [EMAIL PROTECTED]
To: "'[EMAIL PROTECTED]'" <[EMAIL PROTECTED]>
cc:
Subject: RE: Got rid of skeletons? (was: cvs commit:
xml-axis/java/test/ wsdl/multibinding VerifyFilesTestCase.java)
a) Yup, I'm going to add the code back in soon - I'm on conference calls
this afternoon, but will try to do it tonight if I can.
b) My vote is that the default should be no skeletons. We're already
generating a deploy.wsdd, so putting the metadata in there seems way
cleaner to me than generating an entirely different class and delegating
every request through there. Should we take an actual vote on this early
next week?
--Glen
> -----Original Message-----
> From: Russell Butek [mailto:[EMAIL PROTECTED]]
> Sent: Thursday, March 28, 2002 11:53 AM
> To: [EMAIL PROTECTED]
> Subject: Got rid of skeletons? (was: cvs commit:
> xml-axis/java/test/wsdl/multibinding VerifyFilesTestCase.java)
>
>
> Uh... No skeletons is the default? I know we talked about
> getting rid of
> skeletons (which is goodness), but I thought that would be an
> OPTION, not
> the default. IBM STILL wants skeletons! So I hope you add
> back the code
> you excised real soon.
>
> Russell Butek
> [EMAIL PROTECTED]
> ---------------------- Forwarded by Russell Butek/Austin/IBM
> on 03/28/2002
> 10:48 AM ---------------------------
>
>
>
>
>
> [EMAIL PROTECTED] on 03/27/2002 04:58:18 PM
>
> Please respond to [EMAIL PROTECTED]
>
> To: [EMAIL PROTECTED]
> cc:
>
> Subject: cvs commit: xml-axis/java/test/wsdl/multibinding
> VerifyFilesTestCase.java
>
>
>
>
> gdaniels 02/03/27 14:58:18
>
> Modified: java/src/org/apache/axis/wsdl/toJava Emitter.java
> java/test/wsdl Wsdl2javaAntTask.java
> java/test/wsdl/clash VerifyFilesTestCase.java
> java/test/wsdl/multibinding VerifyFilesTestCase.java
> Log:
> Throw the big switch.
>
> Skeletons are no longer created by default.
>
> NOTE that right now the code which uses the skeleton methods to get
> the param names/types etc has been excised. My next step is to add
> that back in as part of the ServiceDesc introspection
> process, so we'll
> still support the old deployment syntax + skeletons.
>
> Revision Changes Path
> 1.29 +1 -1
> xml-axis/java/src/org/apache/axis/wsdl/toJava/Emitter.java
>
> Index: Emitter.java
> ===================================================================
> RCS file:
>
> /home/cvs/xml-axis/java/src/org/apache/axis/wsdl/toJava/Emitter.java,v
> retrieving revision 1.28
> retrieving revision 1.29
> diff -u -r1.28 -r1.29
> --- Emitter.java 22 Mar 2002 17:21:25 -0000 1.28
> +++ Emitter.java 27 Mar 2002 22:58:17 -0000 1.29
> @@ -109,7 +109,7 @@
> protected Definition def = null;
> protected boolean bDebug = false;
> protected boolean bEmitServer = false;
> - protected boolean bDeploySkeleton = true;
> + protected boolean bDeploySkeleton = false;
> protected boolean bEmitTestCase = false;
> protected boolean bVerbose = false;
> protected boolean bGenerateImports = true;
>
>
>
> 1.24 +1 -1 xml-axis/java/test/wsdl/Wsdl2javaAntTask.java
>
> Index: Wsdl2javaAntTask.java
> ===================================================================
> RCS file: /home/cvs/xml-axis/java/test/wsdl/Wsdl2javaAntTask.java,v
> retrieving revision 1.23
> retrieving revision 1.24
> diff -u -r1.23 -r1.24
> --- Wsdl2javaAntTask.java 22 Mar 2002 17:21:25 -0000 1.23
> +++ Wsdl2javaAntTask.java 27 Mar 2002 22:58:17 -0000 1.24
> @@ -77,7 +77,7 @@
> {
> private boolean verbose = false;
> private boolean server = false;
> - private boolean skeletonDeploy = true;
> + private boolean skeletonDeploy = false;
> private boolean testCase = false;
> private boolean noImports = false;
> private boolean all = false;
>
>
>
> 1.5 +0 -2
> xml-axis/java/test/wsdl/clash/VerifyFilesTestCase.java
>
> Index: VerifyFilesTestCase.java
> ===================================================================
> RCS file:
> /home/cvs/xml-axis/java/test/wsdl/clash/VerifyFilesTestCase.java,v
> retrieving revision 1.4
> retrieving revision 1.5
> diff -u -r1.4 -r1.5
> --- VerifyFilesTestCase.java 22 Mar 2002 14:38:45 -0000 1.4
> +++ VerifyFilesTestCase.java 27 Mar 2002 22:58:18 -0000 1.5
> @@ -77,10 +77,8 @@
> protected Set shouldExist() {
> HashSet set = new HashSet();
> set.add("AnotherNonSharedNameImpl.java");
> - set.add("AnotherNonSharedNameSkeleton.java");
> set.add("AnotherNonSharedNameStub.java");
> set.add("NonSharedNameImpl.java");
> - set.add("NonSharedNameSkeleton.java");
> set.add("NonSharedNameStub.java");
> set.add("SharedName_Port.java");
> set.add("SharedName_Service.java");
>
>
>
> 1.3 +0 -3
> xml-axis/java/test/wsdl/multibinding/VerifyFilesTestCase.java
>
> Index: VerifyFilesTestCase.java
> ===================================================================
> RCS file:
>
> /home/cvs/xml-axis/java/test/wsdl/multibinding/VerifyFilesTest
> Case.java,v
> retrieving revision 1.2
> retrieving revision 1.3
> diff -u -r1.2 -r1.3
> --- VerifyFilesTestCase.java 5 Feb 2002 16:22:40 -0000 1.2
> +++ VerifyFilesTestCase.java 27 Mar 2002 22:58:18 -0000 1.3
> @@ -78,14 +78,11 @@
> HashSet set = new HashSet();
> set.add("BindingAllLit.java");
> set.add("BindingAllLitImpl.java");
> - set.add("BindingAllLitSkeleton.java");
> set.add("BindingAllLitStub.java");
> set.add("BindingNoLitImpl.java");
> - set.add("BindingNoLitSkeleton.java");
> set.add("BindingNoLitStub.java");
> set.add("BindingSomeLit.java");
> set.add("BindingSomeLitImpl.java");
> - set.add("BindingSomeLitSkeleton.java");
> set.add("BindingSomeLitStub.java");
> set.add("MbPT.java");
> set.add("MbService.java");
>
>
>
>
>
