cvs commit: xml-axis/java/src/org/apache/axis/wsdl/fromJava DefaultBuilderPortTypeClassRep.java

[tomj]

tomj        02/04/03 12:34:50

  Modified:    java/src/org/apache/axis/wsdl/fromJava
                        DefaultBuilderPortTypeClassRep.java
  Log:
  Fix from David L. Cole [[EMAIL PROTECTED]]:
  
  Line 142 of the getResolvedMethods() is attempting to compare to Strings
  for equality
  using the == operator:
  
                  if (m1.getName() == m2.getName()) {
  
  I think the intention was to perform the operation as follows:
  
       if(m1.getName().equals(m2.getName()){
  
  Revision  Changes    Path
  1.6       +1 -1      
xml-axis/java/src/org/apache/axis/wsdl/fromJava/DefaultBuilderPortTypeClassRep.java
  
  Index: DefaultBuilderPortTypeClassRep.java
  ===================================================================
  RCS file: 
/home/cvs/xml-axis/java/src/org/apache/axis/wsdl/fromJava/DefaultBuilderPortTypeClassRep.java,v
  retrieving revision 1.5
  retrieving revision 1.6
  diff -u -r1.5 -r1.6
  --- DefaultBuilderPortTypeClassRep.java       2 Apr 2002 21:52:32 -0000       1.5
  +++ DefaultBuilderPortTypeClassRep.java       3 Apr 2002 20:34:50 -0000       1.6
  @@ -140,7 +140,7 @@
               for (int j=i+1; j < methods.size(); j++ ) {
                   MethodRep m1 = (MethodRep) methods.elementAt(i);
                   MethodRep m2 = (MethodRep) methods.elementAt(j);
  -                if (m1.getName() == m2.getName()) {
  +                if (m1.getName().equals(m2.getName())) {
                       m2.setName(m2.getName() + "_unique_"  + id);
                       id++;
                   }