----- Original Message ----- From: "Tom Jordahl" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Wednesday, April 17, 2002 07:03 Subject: RE: [Patch] Wsdl2java
> > Steve, > > If this patch is applied, how would the functional tests be affected? If we currently ignore network errors and print stack traces on failure, then we would need the changes to the functional test ant file to preserve the same behavior. yup I hate changing things that may be in use, but with the task currently only in the test source branch, it isnt really in the wild yet, which makes it the last chance to change things, and the last chance to fix defaults to values users would benefit from one option might be to add new magic properties like ant.tasks.axis.wsdltojava.ignorenetworkerrors which you can set once to set the default, which can still be overridden. I could do this if you really want; patching the build files is cleaner. > > Also, you added two new parameters, but didn't add them to the new traceParams() function. oops > If you fix up these two issues, I would be happy to apply the patch for Beta 2. > > Also, this line doesn't inspire confidence: > "Code compiles but not tested; i havent got a test setup here yet" > :-) > Well, the axis test build will work as the functional tests; I didnt have that setup locally as once I noticed that JWS support was broken I rolled back my server to a version which did work. Now that is fixed I can do the tests. ant tasks also need the unit tests to stress all the invalid build options you can send them (missing files, missing urls, not enough params &c). The plan for ant1.5 is to pull the ant TestCase extension class out into its own jar (ant-test-framework-15.jar or something similar, then I can write a test for the task which actually looks at the corner cases of the task attributes.
