Re: cvs commit: xml-axis/java/src/org/apache/axis/transport/httpAxisServlet.java

[Russell Butek]

<releaseManagerHat>
Did this have to go into beta 2?
</releaseManagerHat>

Besides, it broke the build:

type
="junit.framework.AssertionFailedError">junit.framework.AssertionFailedError:

File: C:\xml-axis\java\src\org\apache\axis\transport\http\AxisServlet.java:
Unexpected: log\.(info|warn|error|fatal)[ \t]*\((?![ \t]
*JavaUtils\.getMessage)

      at test.utils.TestSrcContent.testSourceFiles(TestSrcContent.java:71)
      at java.lang.reflect.Method.invoke(Native Method)
      at junit.framework.TestCase.runTest(TestCase.java:166)
      at junit.framework.TestCase.runBare(TestCase.java:140)
      at junit.framework.TestResult$1.protect(TestResult.java:106)
      at junit.framework.TestResult.runProtected(TestResult.java:124)
      at junit.framework.TestResult.run(TestResult.java:109)
      at junit.framework.TestCase.run(TestCase.java:131)
      at junit.framework.TestSuite.runTest(TestSuite.java:173)
      at junit.framework.TestSuite.run(TestSuite.java:168)
      at junit.framework.TestSuite.runTest(TestSuite.java:173)
      at junit.framework.TestSuite.run(TestSuite.java:168)
      at
org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:231)
      at
org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:409)

Russell Butek
[EMAIL PROTECTED]


[EMAIL PROTECTED] on 04/23/2002 04:07:53 PM

Please respond to [EMAIL PROTECTED]

To:    [EMAIL PROTECTED]
cc:
Subject:    cvs commit: xml-axis/java/src/org/apache/axis/transport/http
       AxisServlet.java



rsitze      02/04/23 14:07:53

  Modified:    java/src/org/apache/axis/transport/http AxisServlet.java
  Log:
  Log errors as errors, not debug

  Revision  Changes    Path
  1.95      +5 -3
  xml-axis/java/src/org/apache/axis/transport/http/AxisServlet.java

  Index: AxisServlet.java
  ===================================================================
  RCS file:
  /home/cvs/xml-axis/java/src/org/apache/axis/transport/http/AxisServlet.java,v

  retrieving revision 1.94
  retrieving revision 1.95
  diff -u -r1.94 -r1.95
  --- AxisServlet.java  22 Apr 2002 21:36:31 -0000    1.94
  +++ AxisServlet.java  23 Apr 2002 21:07:53 -0000    1.95
  @@ -435,7 +435,7 @@
               try {
                   engine = getEngine();
               } catch (AxisFault fault) {
  -                log.debug(fault);
  +                log.error(fault);
                   Message msg = new Message(fault);
                   res.setContentType( msg.getContentType() );
                   res.setContentLength( msg.getContentLength() );
  @@ -542,7 +542,8 @@
                       JavaUtils.getMessage("noHeader00", "SOAPAction"),
                       null, null );

  -                 log.debug(af);
  +                log.error(af);
  +
                   throw af;
               }

  @@ -576,7 +577,8 @@
               if(isDebug) log.debug("Return from Axis Engine.");
           }
           catch( Exception e ) {
  -            log.debug(e);
  +            log.error(e);
  +
               if ( e instanceof AxisFault ) {
                   AxisFault  af = (AxisFault) e ;
                   // Should really be doing this with explicit AxisFault