1) Personally, we should say either nothing is logged - I don't like this
- OR log a debug message - which I'd prefer. Saying "do this or that" is
kinda weasely.
2) I guess I agree. If I personally write such code, I would consider that
it's wrong (with the caveat of #3). So if I see this exception show up,
that's a pretty good prod for me to know that I did something I shouldn't
have done.
3) Yes, there will always be deviations. And yes, all deviations should
be well documented.
Russell Butek
[EMAIL PROTECTED]
R J Scheuerle Jr/Austin/IBM@IBMUS on 05/10/2002 12:03:15 PM
Please respond to [EMAIL PROTECTED]
To: [EMAIL PROTECTED]
cc:
Subject: RE: logging question: catch (Exception) throw AxisFault
The development doc needs to be changed to reflect the consensus.
Here are some rules to get the discussion moving:
} catch (Exception e) {
� �// Log or not log ?
� �throw new AxisFault(...);
}
1) If the AxisFault is simply wrapping another exception, then nothing
should be logged (except perhaps debug).
2) If the AxisFault is not wrapping another exception, or if a
non-AxisFault message is thrown, at least an info message should be issued.
3) There will be any deviations to these rules. �The deviations should be
clearly defined in a comment which indicates the reason for the deviation.
(This will prevent the code from being changed back and forth.)
Rich Scheuerle
XML & Web Services Development
512-838-5115 �(IBM TL 678-5115)
Russell
Butek/Austin/IBM � � � � To: � � � �[EMAIL PROTECTED]
@IBMUS � � � � cc:
� � � � Subject: � � � �RE: logging
05/10/2002 10:58 question: catch (Exception) throw AxisFault
AM
Please respond
to axis-dev
I can appreciate that exceptions should be logged, and they ARE still
logged if you turn on debug. �The immediate problem (and there are lesser
ones in the build) is the multithread test case. �When that test pounds the
server with 400 requests it WILL get some connection refused exceptions
(for me, at least, this is usually only a few, but I've had as many as
360). �My test ignores these exceptions, but the build output is flooded
with them when log.info is used.
Russell Butek
[EMAIL PROTECTED]
Tom Jordahl <[EMAIL PROTECTED]> on 05/10/2002 10:47:55 AM
Please respond to [EMAIL PROTECTED]
To: � �"'[EMAIL PROTECTED]'" <[EMAIL PROTECTED]>
cc:
Subject: � �RE: logging question: �catch (Exception) throw AxisFault
+1
See http://marc.theaimsgroup.com/?l=axis-dev&m=102028751728496&w=2
But Richard feels that all exceptions should be logged.
--
Tom Jordahl
-----Original Message-----
From: Russell Butek [mailto:[EMAIL PROTECTED]]
Sent: Friday, May 10, 2002 11:42 AM
To: [EMAIL PROTECTED]
Subject: logging question: catch (Exception) throw AxisFault
Various places in the code are of the form
} catch (Exception e) {
� �log.xxx(... e);
� �throw new AxisFault(...);
}
In some places xxx is debug, others it is info. �I contend that it should
always be debug. �When it's info, then the build's output contains stack
dumps that make reading the output a nuisance. �(These outputs weren't
there in the past.)
Russell Butek
[EMAIL PROTECTED]
