It may be a logical manner, but it's an unknown manner to some of us. I've talked with dims and he's explained it to me thusly:

imports are in 3 consecutive groups:
- everything else in alphabetical order
- javax in alpha-order
- java in alpha-order

I can live with this. I just think it should be written down somewhere - developer's guide - so that we can all follow it rather than always change each other's import orders.

If this is indeed the logical manner you're following, and no-one has a problem with it, I'll document it as such. (Personally, I like the simple alpha order, but I won't -0 yours.)

Russell Butek
[EMAIL PROTECTED]

Please respond to [EMAIL PROTECTED]

To: "'[EMAIL PROTECTED]'" <[EMAIL PROTECTED]>
cc:
Subject: RE: cvs commit: xml-axis/java/src/org/apache/axis/wsdl/symbolTabl e Utils.java




 
I pushed the wrong button in IDEA and it sorted the imports and removed unused ones.  I figured I would just check it in, as it would be general goodness.
 
It groups imports in (what I think) is a logical manner, with the different packages grouped together.
 
Not something I do as a matter of course, but I figured in this case...
 
--
Tom
 
 
-----Original Message-----
From: Russell Butek [mailto:[EMAIL PROTECTED]]
Sent: Monday, June 03, 2002 6:43 AM
To: [EMAIL PROTECTED]
Subject: Re: cvs commit: xml-axis/java/src/org/apache/axis/wsdl/symbolTable Utils.java


Just curious. What was the point of this? The imports used to be in alphabetical order. Now I have no clue what the order is. I don't mind seeing imports cleaned up, but this just rearranged things (and pulled out a few blank lines, which I personally like).

It might be helpful if we could decide on a convention for imports, so that when we're in the mood, we can fix our code to match the convention. But just rearranging things without explanation isn't very useful.

Russell Butek
[EMAIL PROTECTED]

Please respond to [EMAIL PROTECTED]

To: [EMAIL PROTECTED]
cc:
Subject: cvs commit: xml-axis/java/src/org/apache/axis/wsdl/symbolTable Utils.java



tomj         2002/06/02 19:03:32

    Modified:    java/src/org/apache/axis/wsdl/symbolTable  Utils.java
    Log:
    optimze imports
    Revision  Changes     Path
    1.7       +6 -10      xml-axis/java/src/org/apache/axis/wsdl/symbolTable/Utils.java
    Index:  Utils.java
    ===================================================================
    RCS  file:  /home/cvs/xml-axis/java/src/org/apache/axis/wsdl/symbolTable/Utils.java,v
    retrieving  revision 1.6
    retrieving revision 1.7
    diff -u -r1.6 -r1.7
    ---  Utils.java 31 May 2002 19:08:10 -0000 1.6
    +++ Utils.java 3 Jun 2002  02:03:32 -0000 1.7
    @@ -54,20 +54,16 @@
    */
    package  org.apache.axis.wsdl.symbolTable;
    -import  java.util.HashSet;
    -import java.util.Iterator;
    -import  java.util.Vector;
    +import org.apache.axis.Constants;
    +import  org.w3c.dom.NamedNodeMap;
    +import  org.w3c.dom.Node;
    import  javax.wsdl.QName;
    -
    import  javax.xml.rpc.holders.BooleanHolder;
    import  javax.xml.rpc.holders.IntHolder;
    -
    -import  org.apache.axis.Constants;
    -
    -import  org.w3c.dom.NamedNodeMap;
    -
    -import org.w3c.dom.Node;
    +import  java.util.HashSet;
    +import java.util.Iterator;
    +import  java.util.Vector;
    /**
    * This class contains static  utility methods for the  emitter.



Reply via email to