gdaniels 2002/07/03 12:57:48
Modified: java/src/org/apache/axis/deployment/wsdd Tag: beta-3
WSDDDeployableItem.java
java/test/functional Tag: beta-3 TestJAXRPCSamples.java
java/samples/stock Tag: beta-3 ComInfoService.java
java/samples/attachments Tag: beta-3 attachdeploy.wsdd
Log:
Fix WSDD to correctly instantiate chains with type="" attributes.
This was preventing authentication from actually functioning - we should
add negative tests to make sure bad user/passwords actually throw
faults!
Fix JAXRPC test to use authentication, since it's needed now.
Remove authentication from attachments test.
Revision Changes Path
No revision
No revision
1.40.2.1 +15 -6
xml-axis/java/src/org/apache/axis/deployment/wsdd/WSDDDeployableItem.java
Index: WSDDDeployableItem.java
===================================================================
RCS file:
/home/cvs/xml-axis/java/src/org/apache/axis/deployment/wsdd/WSDDDeployableItem.java,v
retrieving revision 1.40
retrieving revision 1.40.2.1
diff -u -r1.40 -r1.40.2.1
--- WSDDDeployableItem.java 1 Jul 2002 17:40:30 -0000 1.40
+++ WSDDDeployableItem.java 3 Jul 2002 19:57:47 -0000 1.40.2.1
@@ -118,7 +118,6 @@
/**
*
* @param e (Element) XXX
- * @param n (String) XXX
* @throws WSDDException XXX
*/
public WSDDDeployableItem(Element e)
@@ -294,12 +293,24 @@
if (scope == SCOPE_SINGLETON) {
synchronized (this) {
if (singletonInstance == null)
- singletonInstance = makeNewInstance(registry);
+ singletonInstance = getNewInstance(registry);
}
return singletonInstance;
}
- return makeNewInstance(registry);
+ return getNewInstance(registry);
+ }
+
+ private Handler getNewInstance(EngineConfiguration registry)
+ throws ConfigurationException
+ {
+ QName type = getType();
+ if (type == null ||
+ WSDDConstants.URI_WSDD_JAVA.equals(type.getNamespaceURI())) {
+ return makeNewInstance(registry);
+ } else {
+ return registry.getHandler(type);
+ }
}
/**
@@ -323,7 +334,6 @@
}
if (c != null) {
-
try {
h = (Handler)createInstance(c);
} catch (Exception e) {
@@ -347,6 +357,7 @@
}
}
} else {
+ // !!! Should never get here!
h = registry.getHandler(getType());
}
@@ -357,7 +368,6 @@
*
* @param _class XXX
* @return XXX
- * @throws Exception XXX
*/
Object createInstance(Class _class)
throws InstantiationException, IllegalAccessException
@@ -367,7 +377,6 @@
/**
*
- * @param type XXX
* @return XXX
* @throws ClassNotFoundException XXX
*/
No revision
No revision
1.6.2.1 +3 -3 xml-axis/java/test/functional/TestJAXRPCSamples.java
Index: TestJAXRPCSamples.java
===================================================================
RCS file: /home/cvs/xml-axis/java/test/functional/TestJAXRPCSamples.java,v
retrieving revision 1.6
retrieving revision 1.6.2.1
diff -u -r1.6 -r1.6.2.1
--- TestJAXRPCSamples.java 1 Jul 2002 17:40:40 -0000 1.6
+++ TestJAXRPCSamples.java 3 Jul 2002 19:57:47 -0000 1.6.2.1
@@ -123,11 +123,11 @@
log.info("Testing deployment...");
doTestDeploy();
log.info("Testing service...");
- String[] args = {"IBM", "symbol"};
+ String[] args = {"-uuser3", "-wpass3", "IBM", "symbol"};
GetInfo.main(args);
- args = new String[] {"ALLR", "name"};
+ args = new String[] {"-uuser3", "-wpass3", "MACR", "name"};
GetInfo.main(args);
- args = new String[] {"CSCO", "address"};
+ args = new String[] {"-uuser3", "-wpass3", "CSCO", "address"};
GetInfo.main(args);
log.info("Testing undeployment...");
doTestUndeploy();
No revision
No revision
1.8.12.1 +2 -2 xml-axis/java/samples/stock/ComInfoService.java
Index: ComInfoService.java
===================================================================
RCS file: /home/cvs/xml-axis/java/samples/stock/ComInfoService.java,v
retrieving revision 1.8
retrieving revision 1.8.12.1
diff -u -r1.8 -r1.8.12.1
--- ComInfoService.java 30 Oct 2001 16:46:32 -0000 1.8
+++ ComInfoService.java 3 Jul 2002 19:57:47 -0000 1.8.12.1
@@ -69,8 +69,8 @@
"International Business Machines",
"Armonk, NY" },
- {"ALLR",
- "Allaire",
+ {"MACR",
+ "Macromedia",
"Newton, MA" },
{"CSCO",
No revision
No revision
1.6.4.1 +0 -1 xml-axis/java/samples/attachments/attachdeploy.wsdd
Index: attachdeploy.wsdd
===================================================================
RCS file: /home/cvs/xml-axis/java/samples/attachments/attachdeploy.wsdd,v
retrieving revision 1.6
retrieving revision 1.6.4.1
diff -u -r1.6 -r1.6.4.1
--- attachdeploy.wsdd 23 Apr 2002 20:22:54 -0000 1.6
+++ attachdeploy.wsdd 3 Jul 2002 19:57:47 -0000 1.6.4.1
@@ -5,7 +5,6 @@
<service name="urn:EchoAttachmentsService" provider="java:RPC" >
<parameter name="className" value="samples.attachments.EchoAttachmentsService"/>
<parameter name="allowedMethods" value="echo echoDir"/>
- <requestFlow type="checks"/>
<operation name="echo" returnQName="returnqname" returnType="ns1:DataHandler" >
<parameter name="dh" type="ns1:DataHandler"/>
</operation>
