I was thinking the same thing when I changed the code.  This would be
appropriate for post 1.0.

This late in the game we don't want to change any public constants.  See
Tom's recent note.

Rich Scheuerle
IBM WebSphere & Axis Web Services Development
512-838-5115  (IBM TL 678-5115)


                                                                                       
                                      
                      Richard                                                          
                                      
                      Sitze/Austin/IBM@        To:       [EMAIL PROTECTED]       
                                      
                      IBMUS                    cc:                                     
                                      
                                               Subject:  RE: cvs commit: 
xml-axis/java/tools/org/apache/axis/tools/ant/wsd   
                      09/26/2002 03:52          l Java2WsdlAntTask.java                
                                      
                      PM                                                               
                                      
                      Please respond to                                                
                                      
                      axis-dev                                                         
                                      
                                                                                       
                                      
                                                                                       
                                      



Rich, might I also suggest that you add the method

        org.apache.axis.enum.Style.getMode()

which returns the appropriate mode for each style?  save yourself a bit of
if-else logic scattered throughout the program...

<ras>

*******************************************
Richard A. Sitze
IBM WebSphere WebServices Development




Tom Jordahl <[EMAIL PROTECTED]>
09/26/2002 03:46 PM
Please respond to axis-dev

        To:     "'[EMAIL PROTECTED]'" <[EMAIL PROTECTED]>
        cc:
        Subject:        RE: cvs commit:
xml-axis/java/tools/org/apache/axis/tools/ant/wsd       l
Java2WsdlAntTask.java




Rich,

Haven't looked through the whole submit, but this sounds great.


   c) Emitter class changed to recognize three styles
       STYLE_DOCUMENT, STYLE_RPC, and STYLE_DOC_WRAPPED.
       (used to have MODE_DOCUMENT and MODE_RPC).


This worries me as it is an API change very late in the game.
Can you at least leave the old values there?

--
Tom Jordahl
Macromedia






Reply via email to