If I understand this change shouldn't a service that has a binding that can not be referenced at least generate some warning?
Rick Rineholt
"The truth is out there... All you need is a better search engine!"
[EMAIL PROTECTED]
Please respond to [EMAIL PROTECTED]
To: [EMAIL PROTECTED]
cc:
Subject: Re: VOTE : RE: cvs commit: xml-axis/java/src/org/apache/axis/wsdl/gen Parser.java
+1 from me.
thanks,
dims
--- Glen Daniels <[EMAIL PROTECTED]> wrote:
>
> All - this is a serious bug, and I think it merits the "we'll look like dorks if it's not fixed"
> label. It changes nothing except that bindings which aren't explicitly referenced (i.e. SOAP
> 1.1) are ignored when generating code. This means that we won't mistakenly generate mismatched
> interfaces and implementations when a SOAP 1.2 binding references a "wrapped" PortType.
>
> I think we should vote to include this in 1.0.
>
> +1 from me.
>
> --Glen
>
> > -----Original Message-----
> > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]
> > Sent: Wednesday, October 02, 2002 1:24 PM
> > To: [EMAIL PROTECTED]
> > Subject: cvs commit: xml-axis/java/src/org/apache/axis/wsdl/gen
> > Parser.java
> >
> >
> > gdaniels 2002/10/02 10:24:03
> >
> > Modified: java/src/org/apache/axis/wsdl/gen Parser.java
> > Log:
> > If a bindingEntry is undefined, don't use it!
> >
> > This prevents problems with SOAP1.2 (or any other unknown) bindings.
> >
> > Fixes bug
> >
> > http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13209
> >
> > (at least in that we generate compilable stuff now)
> >
> > Revision Changes Path
> > 1.12 +1 -1
> > xml-axis/java/src/org/apache/axis/wsdl/gen/Parser.java
> >
> > Index: Parser.java
> > ===================================================================
> > RCS file:
> > /home/cvs/xml-axis/java/src/org/apache/axis/wsdl/gen/Parser.java,v
> > retrieving revision 1.11
> > retrieving revision 1.12
> > diff -u -r1.11 -r1.12
> > --- Parser.java 24 Sep 2002 16:03:38 -0000 1.11
> > +++ Parser.java 2 Oct 2002 17:24:03 -0000 1.12
> > @@ -307,7 +307,7 @@
> > // If the binding is undefined, then
> > we're parsing a Definition
> > // that didn't contain a binding,
> > merely a service that referred
> > // to a non-existent binding. Don't
> > bother writing it.
> > - if (binding.isUndefined()) {
> > + if (binding.isUndefined() ||
> > !bEntry.isReferenced()) {
> > continue;
> > }
> > gen = genFactory.getGenerator(binding,
> > symbolTable);
> >
> >
> >
> >
=====
Davanum Srinivas - http://xml.apache.org/~dims/
__________________________________________________
Do you Yahoo!?
New DSL Internet Access from SBC & Yahoo!
http://sbc.yahoo.com
