RE: cvs commit: xml-axis/java/src/org/apache/axis/encoding/ser ArraySerializer.java

[Vidyanand Murunikkara]

I will keep that in mind when i check in again :)

Thanks
Vidyanand

-----Original Message-----
From: Tom Jordahl [mailto:[EMAIL PROTECTED]]
Sent: Monday, December 09, 2002 6:34 AM
To: '[EMAIL PROTECTED]'
Subject: RE: cvs commit: xml-axis/java/src/org/apache/axis/encoding/ser
ArraySerializer.java



Thanks, this was my bad.  I *did* run all the tests before I checked in.

BTW - a minor nit:
Java/Axis coding standards require the braces {} around the if
statement, even if its only a single statement.  With the first brace on
the same line as the if:

if (msgContext != null) {
   endable2D = ....
}


--
Tom Jordahl
Macromedia Server Development



-----Original Message-----
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]
Sent: Saturday, December 07, 2002 8:23 PM
To: [EMAIL PROTECTED]
Subject: cvs commit: xml-axis/java/src/org/apache/axis/encoding/ser
ArraySerializer.java


vidyanand    2002/12/07 17:22:52

  Modified:    java/src/org/apache/axis/encoding/ser
ArraySerializer.java
  Log:
  Check to see if MessageContext is null before setting the
enable2DArrayEncoding flad
  
  Revision  Changes    Path
  1.43      +6 -3
xml-axis/java/src/org/apache/axis/encoding/ser/ArraySerializer.java
  
  Index: ArraySerializer.java
  ===================================================================
  RCS file:
/home/cvs/xml-axis/java/src/org/apache/axis/encoding/ser/ArraySerializer
.java,v
  retrieving revision 1.42
  retrieving revision 1.43
  diff -u -r1.42 -r1.43
  --- ArraySerializer.java      6 Dec 2002 22:16:52 -0000       1.42
  +++ ArraySerializer.java      8 Dec 2002 01:22:51 -0000       1.43
  @@ -206,9 +206,12 @@
   
           // Check the message context to see if we should turn 2D
processing ON
           // Default is OFF
  -        boolean enable2Dim =
  -            JavaUtils.isTrueExplicitly(context.getMessageContext().
  -
getAxisEngine().getOption(AxisEngine.PROP_TWOD_ARRAY_ENCODING));
  +             boolean enable2Dim = false;
  +             
  +             // Vidyanand : added this check
  +             if( msgContext != null ) 
  +            enable2Dim = 
  +
JavaUtils.isTrueExplicitly(msgContext.getAxisEngine().getOption(AxisEngi
ne.PROP_TWOD_ARRAY_ENCODING));
   
           int dim2Len = -1;
           if (enable2Dim && !dims.equals("")) {