I think the idea of IDEA's ordering is to put the imports that are the most generic 
down at the bottom, i.e. the core java.* classes.  That way the first thing you see is 
specific stuff that's from other codebases, then java extensions, and finally java 
core packages.  I think I actually like that.

That said, I'm fine either way as long as we're consistent, and I could just tell IDEA 
to do it the other way.  So I'll plan to do this end-of-day today, and if you have a 
strong opinion either way, let me know - I'll go with whatever the majority thinks.

--Glen

> -----Original Message-----
> From: Russell Butek [mailto:[EMAIL PROTECTED]]
> Sent: Wednesday, December 11, 2002 8:37 AM
> To: [EMAIL PROTECTED]
> Subject: Re: FW: Unused imports
> 
> 
> 
> 
> 
> 
> Consistency is more important than any particular pattern - I 
> personally
> would prefer everything alphabetized - but I thought we 
> discussed this a
> few months ago and decided on 2 groups:  first the non-Java stuff,
> alphabetized, then the Java stuff, alphabetized.  Since '.' 
> is before 'x',
> this would be:
> 
> <all other imports>
> java.
> javax.
> 
> Like I said, though, consistency is most important, so +1 
> from me, even if
> you put javax before java.
> 
> Russell Butek
> [EMAIL PROTECTED]
> 
> 
> 
>                                                               
>                                                                     
>                       Glen Daniels                            
>                                                                     
>                       <gdaniels@macrome        To:       
> "'Axis-Dev (E-mail)'" <[EMAIL PROTECTED]>               
>            
>                       dia.com>                 cc:            
>                                                                     
>                                                Subject:  FW: 
> Unused imports                                                       
>                       12/10/2002 12:39                        
>                                                                     
>                       PM                                      
>                                                                     
>                       Please respond to                       
>                                                                     
>                       axis-dev                                
>                                                                     
>                                                               
>                                                                     
>                                                               
>                                                                     
> 
> 
> 
> 
> 
> Axis-dev'ers:
> 
> I agree with this being an issue.  Here's my suggestion.
> 
> I'll volunteer to do a single commit cleaning up all the 
> imports in the
> project, using IDEA.  After that we can just be careful about 
> introducing /
> removing imports appropriately.  IDEA will order the imports 
> as follows:
> 
> <all other imports>
> <blank line>
> javax. and everything under it
> java. and everything under it
> 
> all alphabetically.
> 
> Any objections, +1s, other options?
> 
> --Glen
> 
> -----Original Message-----
> From: Vladimir R. Bossicard [mailto:[EMAIL PROTECTED]]
> Sent: Tuesday, December 10, 2002 11:17 AM
> To: [EMAIL PROTECTED]
> Subject: Unused imports
> 
> 
> Hi all,
> 
> I don't know if this was already discussed on this ml (archive not
> available) and if you already read general@jakarta, sorry to 
> reintroduce
> the subject.
> 
> Tom Copeland has created a report about the unused imports of the xml
> apache projects 
<http://cvs.apache.org/~tcopeland/jakarta_bad_imports.htm>.

               #imports  #bad
xml-axis       40,946    532  1.30%
xml-batik      94,300  1,047  1.11%
xml-cocoon      6,384     26  0.41%
xml-cocoon2    43,136    616  1.43%
xml-commons     4,060    120  2.96%
xml-crimson     7,883     46  0.58%
xml-fop        28,210    328  1.16%
xml-rpc         2,921     11  0.38%
xml-security   12,775    361  2.83%
xml-soap        8,844     31  0.35%
xml-stylebook   2,100     52  2.48%
xml-xerces     54,472    406  0.75%
xml-xindice    12,885      8  0.06%

Should be better IMO.

Every IDE (Eclipse, IntelliJ) has an "optimize imports" option so it
will not take long to fix the imports.  Furthermore it will show that we
really care about our source code.

-Vladimir

--
Vladimir R. Bossicard
Apache Xindice - http://xml.apache.org/xindice


---------------------------------------------------------------------
In case of troubles, e-mail:     [EMAIL PROTECTED]
To unsubscribe, e-mail:          [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


Reply via email to