DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15741>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15741

TCP Monitor does not handle WebDAV methods in proxy mode





------- Additional Comments From [EMAIL PROTECTED]  2002-12-31 21:18 
-------
It is dangerous to assume a connection is HTTP if it begins with an HTTP method
name. Many TCP protocols are plaintext request/response pairs and may even use
the same command names (GET and POST are quite common verbs.) A better option
would be to have the user of tcpmon select whether the connections are to be
HTTP or not.

In one case (the lower if) it is only used in proxy mode (which, by definition,
must be HTTP.)  The upper, however, is in resend() which is used for both proxy
and listener mode.

Upon reviewing the resend() function, it contains two critical flaws:

If I do multiple HTTP requests in the same connection, then click "resend", all
of the requests of the connection are sent again...AND the Content-Length of the
first one is recalculated to include the length of the buffer (including further
requests.)

Second, it appears that the host and port are determined based on the first
request only, which is not correct behavior. Each request will likely be sent to
a different destination host.

It seems to me that the whole function should be rewritten. These bugs have
nothing to do with the code to determine whether it's an HTTP request or not.

Reply via email to