Dahut Nacho!
Michael A Nachbaur wrote:
Essentially, this patch intends to add the "AxXMLCatalog" Apache directive which defines which XML catalogs to include into XML::LibXML.
I think this is a useful and valuable thing to add. Just a few comments.
+sub XMLCatalogs {
+ my $self = shift;
+ + my @others;
+ + print STDERR "XML Catalog: ", join(", ", %{ $self->{cfg}{XMLCatalogs} } ), "\n";
You might want to drop that line :) (and why not use warn instead?).
+=head2 AxXMLCatalog + +Use this directive to add additional XML catalogs to the XML transformation +engine. XML Catalogs provide an interoperable way to map information about +an XML resource to a URI reference. This enables you to, among other things, +define custom URIs representing files or sections of your site, making +references to such resources more portable. + + AxXMLCatalog /catalog.xml
Reading this it's unclear to me whether that path is from the docroot (as most Apache configuration parameters are) or if it's from the FS root (as one often specifies catalogs).
Apart from that, it looks perfect :)
-- Robin Berjon
