-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Saturday 29 June 2002 6:47 pm, Daisuke Maki wrote: > > That sounds very smart indeed! Please do so - I'd love to have that > > patch! > > Cool :) Attatched is the bare-bones patch. > > And here are few things you might want to consider... : > > 1) in main_handler(), $E is checked against Error::Simple as well. > However, if $E is a Error::Simple object and $E->as_xml is called, my > patch would obviously break. But then again, process_error() used to > call $E->stacktrace_list() which is not in Error::Simple anyway, so I > guess this doesn't matter... (b/c Error::Simple never actually gets > raised ? ) ?
Code to check for Error::Simple removed (should *never* happen). > 2) I seem to remember that you wanted to separate out the mod_perl > related stuff from AxKit specific functions. process_error() currently > uses $r to grab the filename out of it. So in order to allow both > mod_perl and non-mod_perl usage, I currently have $E->as_xml accept an > optional parameter, $r. If $r is present, then $r->filename is used. > Otherwise $E->file is used. I didn't know how you wanted to do this, so > let me know if that doesn't work... If this functionality is not > required, I could just grab Apache->request from as_xml(). Modified to pass in a filename, not $r, and use $E->filename not $E->file. > 3) xml_escape() is defined in AxKit.pm, so I just used > AxKit::xml_escape($str) from Apache::AxKit::Exception. I find this > rather ugly, but again, I didn't know how you wanted to handle it, so I > just used it as is. Perhaps an equivalent of HTML::Entities should be > uploaded to CPAN to handle these things for XML... That's fine. Applied and checked in. - -- <:->get a SMart net</:-> -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.7 (GNU/Linux) iD8DBQE9HjB6VBc71ct6OywRAv6zAKDF2U8Vawax1kZbVwujRdlTo538HQCcDM2I KsbN9Dce3B2lOmTyO8Dz+WM= =gbIM -----END PGP SIGNATURE----- --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
