Review: Approve The code is sane. The unit tests give some extra safety in case of further refactoring.
On the approach, we've discussed the merits of distinguishing between: - placement options, knowing that we not support all gravity options, but maybe different placement strategies for the same "gravity" - slot allocations optimizations, like avoid "gaps" between bubbles at all costs, vs, accepting gaps but having a strict mapping between notification types (sync/async) and slot positioning The code can go in as is. You can optionally refine these 2 last bits later, time permitting before the UIF. -- https://code.edge.launchpad.net/~macslow/notify-osd/two-slots/+merge/11168 Your team ayatana-commits is subscribed to branch lp:notify-osd. _______________________________________________ Mailing list: https://launchpad.net/~ayatana-commits Post to : [email protected] Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
