> The changes with the weak reference callback are good. > > There is one spurious g_print to remove.
Fixed and pushed. > Also, you've commented out the code that acknowledges a notify-close call: it > seems like a regression, you need to support closing bubbles programmatically, > and avoid crashing if you try to do so on a bubble that doesn't exist anymore. But that is for DBus, thus external control, which we do not want in notify-osd. No external application should be able to close a notification-bubble. Only notify-osd (class Stack) is allowed to have that control. -- https://code.edge.launchpad.net/~macslow/notify-osd/fix-427924/+merge/12281 Your team ayatana-commits is subscribed to branch lp:notify-osd. _______________________________________________ Mailing list: https://launchpad.net/~ayatana-commits Post to : [email protected] Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
