Looks sane to me, though I'm not a notify-OSD committer. It would be good to factor out the logfile name selection and add a test to demonstrate that your needs are met, but if you don't feel like doing that, perhaps a comment [so that this doesn't get changed incorrectly in the future] would be useful.
-Rob -- https://code.launchpad.net/~qense/notify-osd/fix-465801/+merge/14265 Your team ayatana-commits is subscribed to branch lp:notify-osd. _______________________________________________ Mailing list: https://launchpad.net/~ayatana-commits Post to : [email protected] Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
