Review: Approve review: approve This is a clear reduction in duplicate code so +1. I'll note though that it may be a little hard to scale up and work with vs structuring it as some code with overridable helpers, or a set of callable trivial functions. But that can be examined in future.
-Rob -- https://code.launchpad.net/~ted/indicator-applet/code-unification/+merge/16809 Your team ayatana-commits is subscribed to branch lp:indicator-applet. _______________________________________________ Mailing list: https://launchpad.net/~ayatana-commits Post to : [email protected] Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
