On Thu, 2010-02-18 at 09:02 +0000, Neil J. Patel wrote: > - You could just send (GFunc)g_object_unref instead of having an explicit > func_unref function to the g_list_foreach (though I see why you may not > want to).
Yeah, I think the problem there is that it's hard to see what you're casting to what. That's why I like the explicit way so that you can see what's being dropped more easily. > - I'd set priv->listener = NULL; after unreffing it, as you've done for > the other properties in dispose Fixed r180. > - When accessing AppMenuItem through `gpointer data` in callbacks, I'd > do a g_return_if_fail (APP_IS_MENU_ITEM (data)) first, as the data > arguments aren't "protected" during signal emission (e.g. ref, emit, > unref for objects). Fixed r181. -- https://code.launchpad.net/~ted/indicator-messages/dynamic-commands/+merge/19570 Your team ayatana-commits is subscribed to branch lp:indicator-messages. _______________________________________________ Mailing list: https://launchpad.net/~ayatana-commits Post to : [email protected] Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
