Review: Needs Information
I'd like to see some unit tests that show how the code now handles corner cases 
properly, typically with pa not being available at startup, then appearing, the 
flipping ten times. Do you have a test environment that can simulate that 
situation?

To improve the readability of the merge proposals, can you also embed some 
emacs or vi tab setttings in your files?
-- 
https://code.launchpad.net/~cjcurran/indicator-sound/stable-service-with-unstable-pulse/+merge/20224
Your team ayatana-commits is subscribed to branch lp:indicator-sound.

_______________________________________________
Mailing list: https://launchpad.net/~ayatana-commits
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~ayatana-commits
More help   : https://help.launchpad.net/ListHelp

Reply via email to